Skip to content

prefer repeat_n() over repeat().take() #147464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2025
Merged

prefer repeat_n() over repeat().take() #147464

merged 1 commit into from
Oct 8, 2025
+1 −1

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Oct 8, 2025

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Oct 8, 2025

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 8, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 8, 2025

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@saethlin
Copy link
Member

saethlin commented Oct 8, 2025

r? saethlin
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 8, 2025

📌 Commit 70a357a has been approved by saethlin

It is now in the queue for this repository.

@rustbot rustbot unassigned lcnr Oct 8, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 8, 2025
Merged
bors added a commit that referenced this pull request Oct 8, 2025
@bors
Auto merge of #147475 - matthiaskrgr:rollup-iyrkv0g, r=matthiaskrgr
7a52736 
Rollup of 6 pull requests

Successful merges:

 - #144006 (clarify wording of match ergonomics diagnostics (`rust_2024_incompatible_pat` lint and error))
 - #147386 (some more `proc_macro` cleanups)
 - #147412 (Convert impossible cases in macro resolution into assertions)
 - #147464 (prefer repeat_n() over repeat().take())
 - #147469 (Add rustdoc crate name in error)
 - #147472 (refactor: replace `LLVMRustAtomicLoad/Store` with LLVM built-in functions)

r? `@ghost`
`@rustbot` modify labels: rollup
@chenyukang chenyukang mentioned this pull request Oct 8, 2025
Merged
@bors bors merged commit 795bbaa into rust-lang:master Oct 8, 2025
10 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 8, 2025
rust-timer added a commit that referenced this pull request Oct 8, 2025
@rust-timer
Unrolled build for #147464
b33f5e9 
Rollup merge of #147464 - RalfJung:repeat, r=saethlin

prefer repeat_n() over repeat().take()
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 9, 2025
@Zalathar
Rollup merge of rust-lang#147489 - chenyukang:yukang-prefer-repeat-n,…
1201c90 
… r=Kivooeo,oli-obk

Prefer to use repeat_n over repeat().take()

More from rust-lang#147464, but batch processed with `ast-grep` to find and replace.

second commit add notes for library: rust-lang@affaf53

r? `@RalfJung`
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 9, 2025
@Zalathar
Rollup merge of rust-lang#147489 - chenyukang:yukang-prefer-repeat-n,…
9ace0de 
… r=Kivooeo,oli-obk

Prefer to use repeat_n over repeat().take()

More from rust-lang#147464, but batch processed with `ast-grep` to find and replace.

second commit add notes for library: rust-lang@affaf53

r? ``@RalfJung``
rust-timer added a commit that referenced this pull request Oct 9, 2025
@rust-timer
Unrolled build for #147489
f12d66b 
Rollup merge of #147489 - chenyukang:yukang-prefer-repeat-n, r=Kivooeo,oli-obk

Prefer to use repeat_n over repeat().take()

More from #147464, but batch processed with `ast-grep` to find and replace.

second commit add notes for library: affaf53

r? ``@RalfJung``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@saethlin saethlin

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.92.0
Development

Successfully merging this pull request may close these issues.
5 participants
@RalfJung @rustbot @saethlin @bors @lcnr