Skip to content

refactor: replace LLVMRustAtomicLoad/Store with LLVM built-in functions #147472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2025
Merged

refactor: replace LLVMRustAtomicLoad/Store with LLVM built-in functions #147472

merged 1 commit into from
Oct 8, 2025
+7 −70

Conversation

AMS21
Copy link
Contributor

@AMS21 AMS21 commented Oct 8, 2025

This simplifies the code and reduces the burden of maintaining our own wrappers.

Work towards #46437

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 8, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 8, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

nikic
nikic reviewed Oct 8, 2025
View reviewed changes
@AMS21 AMS21 force-pushed the remove_llvm_rust_atomics branch from 01d09e1 to 1aed495 Compare October 8, 2025 11:54
@nikic
Copy link
Contributor

nikic commented Oct 8, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 8, 2025

📌 Commit 1aed495 has been approved by nikic

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 8, 2025
Merged
bors added a commit that referenced this pull request Oct 8, 2025
@bors
Auto merge of #147475 - matthiaskrgr:rollup-iyrkv0g, r=matthiaskrgr
7a52736 
Rollup of 6 pull requests

Successful merges:

 - #144006 (clarify wording of match ergonomics diagnostics (`rust_2024_incompatible_pat` lint and error))
 - #147386 (some more `proc_macro` cleanups)
 - #147412 (Convert impossible cases in macro resolution into assertions)
 - #147464 (prefer repeat_n() over repeat().take())
 - #147469 (Add rustdoc crate name in error)
 - #147472 (refactor: replace `LLVMRustAtomicLoad/Store` with LLVM built-in functions)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 359bfa9 into rust-lang:master Oct 8, 2025
10 checks passed
rust-timer added a commit that referenced this pull request Oct 8, 2025
@rust-timer
Unrolled build for #147472
41632e3 
Rollup merge of #147472 - AMS21:remove_llvm_rust_atomics, r=nikic

refactor: replace `LLVMRustAtomicLoad/Store` with LLVM built-in functions

This simplifies the code and reduces the burden of maintaining our own wrappers.

Work towards #46437
@rustbot rustbot added this to the 1.92.0 milestone Oct 8, 2025
@AMS21 AMS21 deleted the remove_llvm_rust_atomics branch October 8, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic left review comments

Assignees

@davidtwco davidtwco

Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.92.0
Development

Successfully merging this pull request may close these issues.
5 participants
@AMS21 @rustbot @nikic @bors @davidtwco