Skip to content

Add rustdoc crate name in error #147469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2025
Merged

Add rustdoc crate name in error #147469

merged 1 commit into from
Oct 8, 2025
+20 −6

Conversation

Jamesbarford
Copy link
Contributor

@Jamesbarford Jamesbarford commented Oct 8, 2025 •
edited by fmease
Loading

Fixes #147458

I'm not entirely sure if what I am doing with the span is correct

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 8, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 8, 2025

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@GuillaumeGomez
Copy link
Member

Please add a regression test in tests/rustdoc-ui.

@Jamesbarford
Copy link
Contributor Author

4d0da5e has updated the tests which in turn, I believe, should be a regression test.

GuillaumeGomez
GuillaumeGomez reviewed Oct 8, 2025
View reviewed changes
GuillaumeGomez
GuillaumeGomez reviewed Oct 8, 2025
View reviewed changes
@GuillaumeGomez
Copy link
Member

Once my last comment fixed, please squash your commits then once CI is happy, I'll approve it. Thanks for the fix!

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@chenyukang
Copy link
Member

chenyukang commented Oct 8, 2025 •
edited
Loading

I'm curious, why your PR title have Fix;, it's a type of Fix:? 😆
seems in this repo we don't add prefix such as Fix: or Chore: etc.

@Jamesbarford Jamesbarford force-pushed the fix/crate-error-message branch from af13d7f to d6defe6 Compare October 8, 2025 10:23
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Jamesbarford Jamesbarford force-pushed the fix/crate-error-message branch from d6defe6 to 2c1e796 Compare October 8, 2025 10:35
@Jamesbarford Jamesbarford changed the title Fix; add rustdoc crate name in error Add rustdoc crate name in error Oct 8, 2025
@Jamesbarford
Copy link
Contributor Author

I'm curious, why your PR title have Fix;, it's a type of Fix:? 😆 seems in this repo we don't add prefix such as Fix: or Chore: etc.

No strong reason, I've removed it 👍

@GuillaumeGomez
Copy link
Member

Looks good to me, thanks! r=me once CI pass.

@bors delegate+

@bors
Copy link
Collaborator

bors commented Oct 8, 2025

✌️ @Jamesbarford, you can now approve this pull request!

If @GuillaumeGomez told you to "r=me" after making some further change, please make that change, then do @bors r=@GuillaumeGomez

@Jamesbarford
Copy link
Contributor Author

Thanks

@bors r=@GuillaumeGomez

@bors
Copy link
Collaborator

bors commented Oct 8, 2025

📌 Commit 2c1e796 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 8, 2025
Merged
@GuillaumeGomez
Copy link
Member

@bors rollup

bors added a commit that referenced this pull request Oct 8, 2025
@bors
Auto merge of #147475 - matthiaskrgr:rollup-iyrkv0g, r=matthiaskrgr
7a52736 
Rollup of 6 pull requests

Successful merges:

 - #144006 (clarify wording of match ergonomics diagnostics (`rust_2024_incompatible_pat` lint and error))
 - #147386 (some more `proc_macro` cleanups)
 - #147412 (Convert impossible cases in macro resolution into assertions)
 - #147464 (prefer repeat_n() over repeat().take())
 - #147469 (Add rustdoc crate name in error)
 - #147472 (refactor: replace `LLVMRustAtomicLoad/Store` with LLVM built-in functions)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f6caa5f into rust-lang:master Oct 8, 2025
10 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 8, 2025
rust-timer added a commit that referenced this pull request Oct 8, 2025
@rust-timer
Unrolled build for #147469
e22d9ea 
Rollup merge of #147469 - Jamesbarford:fix/crate-error-message, r=GuillaumeGomez

Add rustdoc crate name in error

Fixes #147458

I'm not entirely sure if what I am doing with the span is correct
@Jamesbarford Jamesbarford deleted the fix/crate-error-message branch October 9, 2025 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

rustdoc::missing-crate-level-docs doesn't have a Span or give the name of the affected crate

6 participants

@Jamesbarford @rustbot @GuillaumeGomez @rust-log-analyzer @chenyukang @bors