-
Notifications
You must be signed in to change notification settings - Fork 13.9k
Rollup of 4 pull requests #147884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 4 pull requests #147884
Conversation
Previously, this was greedily stolen by the `fn` parsing logic.
Refactor move analysis subpath representation Follow up to rust-lang#147055 This PR does two things: 1. Document/validate move analysis's assumptions about `Subslice` projections 2. Decouple move paths from `ProjectionElem`, using a new enum `MoveSubPath` instead - This would be needed eventually when `ProjectionElem::Deref` is removed I wanted to do even more abstraction, making `MovePathLookup::find` return an iterator to remove the special handling of subslices in borrowck, but that regressed diagnostics and just wasn't worth the complexity.
… r=fmease Parse `const unsafe trait` properly Previously, this was greedily stolen by the `fn` parsing logic. r? project-const-traits
MirPatch: Simplify new_local. Small simplification.
…asko comments for deduce_param_attrs Cc `@saethlin` since IIRC you experimented with codegen doing post-mono MIR ops? That seems to be in conflict with this pass. Cc `@tmiasko` r? `@scottmcm`
@bors r+ rollup=never p=5 |
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
☀️ Test successful - checks-actions |
📌 Perf builds for each rolled up PR:
previous master: c6efb9019b In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing c6efb90 (parent) -> 4ddbb60 (this PR) Test differencesShow 50 test diffsStage 1
Stage 2
Additionally, 48 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 4ddbb6051271237f4192333e06b8129148995eef --output-dir test-dashboard And then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Successful merges:
const unsafe trait
properly #147864 (Parseconst unsafe trait
properly)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup