Skip to content

Conversation

matthiaskrgr
Copy link
Member

@matthiaskrgr matthiaskrgr commented Oct 19, 2025

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

beepster4096 and others added 12 commits October 11, 2025 22:49
Previously, this was greedily stolen by the `fn` parsing logic.
Refactor move analysis subpath representation

Follow up to rust-lang#147055

This PR does two things:
1. Document/validate move analysis's assumptions about `Subslice` projections
2. Decouple move paths from `ProjectionElem`, using a new enum `MoveSubPath` instead
    - This would be needed eventually when `ProjectionElem::Deref` is removed

I wanted to do even more abstraction, making `MovePathLookup::find` return an iterator to remove the special handling of subslices in borrowck, but that regressed diagnostics and just wasn't worth the complexity.
… r=fmease

Parse `const unsafe trait` properly

Previously, this was greedily stolen by the `fn` parsing logic.

r? project-const-traits
MirPatch: Simplify new_local.

Small simplification.
…asko

comments for deduce_param_attrs

Cc `@saethlin` since IIRC you experimented with codegen doing post-mono MIR ops? That seems to be in conflict with this pass.
Cc `@tmiasko`

r? `@scottmcm`
@rustbot rustbot added A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Oct 19, 2025
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Oct 19, 2025

📌 Commit 362c9e2 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2025
bors added a commit that referenced this pull request Oct 19, 2025
Rollup of 4 pull requests

Successful merges:

 - #147575 (Refactor move analysis subpath representation)
 - #147864 (Parse `const unsafe trait` properly)
 - #147868 (MirPatch: Simplify new_local.)
 - #147873 (comments for deduce_param_attrs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Collaborator

bors commented Oct 19, 2025

⌛ Testing commit 362c9e2 with merge b4f28c6...

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-msvc-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

error: test failed, to rerun pass `-p std --test sync`
Bootstrap failed while executing `test --stage 2 --skip=compiler --skip=src`
Build completed unsuccessfully in 1:51:44
make: *** [Makefile:112: ci-msvc-py] Error 1
  local time: Sun Oct 19 17:03:57 CUT 2025
  network time: Sun, 19 Oct 2025 17:03:57 GMT
##[error]Process completed with exit code 2.
##[group]Run echo "disk usage:"
echo "disk usage:"

@bors
Copy link
Collaborator

bors commented Oct 19, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 19, 2025
@matthiaskrgr
Copy link
Member Author

@bors retry
#147885

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2025
@bors
Copy link
Collaborator

bors commented Oct 19, 2025

⌛ Testing commit 362c9e2 with merge 4ddbb60...

@bors
Copy link
Collaborator

bors commented Oct 19, 2025

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 4ddbb60 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 19, 2025
@bors bors merged commit 4ddbb60 into rust-lang:master Oct 19, 2025
12 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 19, 2025
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#147575 Refactor move analysis subpath representation a14017dafea20e672b499728eb0d8d08134ef176 (link)
#147864 Parse const unsafe trait properly cc0071a62edf32b61ee32094c472ab23820983d1 (link)
#147868 MirPatch: Simplify new_local. 749cc9d793d0dbfd8460a7ef2f7c0b11b0464bc3 (link)
#147873 comments for deduce_param_attrs 1be004b6b70de1bf33b42bb5b252ad28588de7f0 (link)

previous master: c6efb9019b

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c6efb90 (parent) -> 4ddbb60 (this PR)

Test differences

Show 50 test diffs

Stage 1

  • [ui] tests/ui/traits/const-traits/parse-const-unsafe-trait.rs: [missing] -> pass (J1)

Stage 2

  • [ui] tests/ui/traits/const-traits/parse-const-unsafe-trait.rs: [missing] -> pass (J0)

Additionally, 48 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 4ddbb6051271237f4192333e06b8129148995eef --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-apple: 7245.5s -> 5659.3s (-21.9%)
  2. pr-check-1: 1832.3s -> 1491.8s (-18.6%)
  3. x86_64-gnu-distcheck: 6929.1s -> 6263.6s (-9.6%)
  4. aarch64-msvc-2: 5324.9s -> 4845.8s (-9.0%)
  5. dist-loongarch64-linux: 5243.9s -> 5669.4s (8.1%)
  6. dist-ohos-armv7: 4391.3s -> 4035.6s (-8.1%)
  7. dist-loongarch64-musl: 5417.6s -> 4982.2s (-8.0%)
  8. armhf-gnu: 5317.4s -> 4894.4s (-8.0%)
  9. dist-aarch64-windows-gnullvm: 4750.5s -> 4374.7s (-7.9%)
  10. dist-various-1: 4226.2s -> 3892.7s (-7.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rustc-dev-guide Area: rustc-dev-guide merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants