Skip to content

Conversation

@GuillaumeGomez
Copy link
Member

Just realized that the help menu mentions the list of available search item type filters... but it's also very incomplete and the book says the full list is provided there.

Considering that search.js is supposed to be self-contained (for our testsuite mostly) and that we don't want to add an extra step to generate JS (so we can copy-paste it around and just test it), I'm not too sure what would be the best solution here.

Anyway, question for future us, in the meantime, this adds the missing entries in the help menu:

image

r? @lolbinarycat

@rustbot
Copy link
Collaborator

rustbot commented Oct 20, 2025

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha, @lolbinarycat

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 20, 2025
@rustbot rustbot added the T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. label Oct 20, 2025
@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez
Copy link
Member Author

r? @notriddle

@rustbot rustbot assigned notriddle and unassigned lolbinarycat Oct 24, 2025
@notriddle
Copy link
Contributor

Ick, no. That is way too long for a flat list like that. Maybe, instead?

Accepted kinds are:

  • struct, enum, union
  • structfield, variant
  • type: primitive, associatedtype
  • constant: associatedconstant
  • fn: method, tymethod
  • trait: traitalias
  • macro: attr, derive (NOTE: typePassesFilter doesn't implement this, but it should)
  • import: externcrate (NOTE: typePassesFilter doesn't implement this, but it should)
  • keyword, attribute
  • mod
  • static
  • foreigntype
  • generic

existential and impl exist in the code, but are anonymous, so you can't actually use them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants