Rollup of 5 pull requests #147928

Zalathar · 2025-10-21T01:20:59Z

Successful merges:

move once module out of poison #147125 (move once module out of poison)
Add Cacheable trait alias in rustc_public_bridge #147800 (Add Cacheable trait alias in rustc_public_bridge)
rustdoc search: relax rules for identifiers #147860 (rustdoc search: relax rules for identifiers)
Update books #147916 (Update books)
rustc-dev-guide subtree update #147924 (rustc-dev-guide subtree update)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

name of the tool is lower case

Remove outdated recurring work item

Update to new `S-waiting-on-compiler` and `I-compiler-nominated` labels

Add debug assertions flag to `cg_gcc` invocation

Fix and improve guidance for building/rebuilding the compiler

Overhaul GCC codegen backend section

It is a bit confusing when reading code that uses this type since it is not immediately obvious that it is specific to `Once`. Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>

Moves things around to make a bit more sense (plus prepare moving `once` out of `poison`. Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>

Since `Once` will not have a non-poisoning variant, we remove it from the `poison` module. Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>

They are the same thing since they can be converted back and forth without loss.

debugging.md: Remove wrong claim that LLVM bitcode is not the same as LLVM IR

…=tgross35 move `once` module out of `poison` From rust-lang#134645 (comment), since `Once` will not have a non-poisoning variant, we remove it from the `poison` module. Additionally: 1. Renames `once::ExclusiveState` to `OnceExclusiveState` since it was a bit confusing reading just `ExclusiveState` where it is used. 2. Reorders a few module definitions and re-exports in `library/std/src/sync/mod.rs` for clarity. Also, once this is merged, I think that we can begin the process of stabilizing [`sync_poison_mod`](rust-lang#134646)

Add `Cacheable` trait alias in `rustc_public_bridge` r? `@celinval`

…ident-rules, r=notriddle,GuillaumeGomez rustdoc search: relax rules for identifiers fixes rust-lang#147763

Update books ## rust-lang/book 68 commits in 1d7c3e6abec2d5a9bfac798b29b7855b95025426..af415fc6c8a6823dfb4595074f27d5a3e9e2fe49 2025-10-20 14:01:39 UTC to 2025-01-21 22:49:39 UTC - Prepare for renaming of rust-lang/rust default branch (rust-lang/book#4534) - Adding Uzbek translated rust-book repository to the list (rust-lang/book#4387) - I have added Bengali Translation of The Book. (rust-lang/book#4476) - Add+ vietnamese language translate (rust-lang/book#4368) - Appendix B and Appendix D from tech review (rust-lang/book#4466) - Chapter 21 from tech review (rust-lang/book#4464) - Chapter 20 from tech review (rust-lang/book#4460) - Chapter 19 from tech review (rust-lang/book#4446) - Chapter 18 from tech review (rust-lang/book#4445) - Chapter 16 from tech review (rust-lang/book#4438) - WIP ch 17 edits after tech review (rust-lang/book#4319) - Chapter 15 from tech review (rust-lang/book#4433) - Chapter 14 from tech review (rust-lang/book#4423) - Chapter 13 from tech review (rust-lang/book#4421) - Chapter 12 from tech review (rust-lang/book#4410) - Chapter 11 from tech review (rust-lang/book#4391) - Chapter 10 from tech review (rust-lang/book#4379) - Chapter 9 from tech review (rust-lang/book#4377) - Chapter 8 from tech review (rust-lang/book#4378) - Chapter 7 from tech review (rust-lang/book#4374) - Chapter 6 from tech review (rust-lang/book#4370) - Chapter 5 from tech review (rust-lang/book#4359) - Chapter 4 from tech review (rust-lang/book#4358) - Chapter 3 from tech review (rust-lang/book#4353) - Ch01+ch02 after tech review (rust-lang/book#4329) - Ch. 21: call out Chrome multiple-connections issue (rust-lang/book#4297) - Ch. 16: refactor 16-6 to using listing component (rust-lang/book#4295) - Ch. 01: Show how to work offline (rust-lang/book#4294) - Ch. 07: Clarify sentences about `pub use` (rust-lang/book#4293) - Ch. 02: Consistent ordering of `use` statements (rust-lang/book#4292) - Anchors on listings (rust-lang/book#4271) - Ch. 17: another tweak to how we phrase things about sections (rust-lang/book#4288) - Ch. 20: correct listing number (rust-lang/book#4287) - Ch. 10.3: clarify language detail (rust-lang/book#4284) - Ch. 17: minor typos and link reference (rust-lang/book#4286) - Ch. 9: correctly demonstrate privacy with module (rust-lang/book#4282) - Ch. 18: correct discussion of delegation in `Post` methods (rust-lang/book#4281) - Ch. 20: tell folks to see the Reference for more ABI info (rust-lang/book#4165) - Ch 10.1 minor clarifications (rust-lang/book#4256) - Clarified the misunderstanding b/w crates, module, items (rust-lang/book#4232) - Ferris: always show, even when it’s small (rust-lang/book#4280) - Ch. 17: mention `use std::pin::{Pin, pin};` on introduction (rust-lang/book#4279) - Persist printing error, NOT ErrorKind (rust-lang/book#4259) - Typo: "2" should be "2 seconds" (rust-lang/book#4263) - Ch. 17: fix tiny example consistency issue (rust-lang/book#4270) - Bump ring from 0.17.8 to 0.17.13 in /listings/ch17-async-await/listing-17-02 (rust-lang/book#4261) - Bump ring from 0.17.8 to 0.17.14 in /packages/trpl (rust-lang/book#4273) - 2024 Print Edition: updates to Word docs and more fixes to Markdown text (rust-lang/book#4272) - Ch. 10: Make social media discussion generic. (rust-lang/book#4249) - Another Ch. 17 -> 18 fix (rust-lang/book#4247) - Ch. 05: further tweak to wording about `user1` availability (rust-lang/book#4246) - Ch. 02: Fix rand version mistake (from testing) (rust-lang/book#4245) - Ch. 19: Correct the discussion of `fn` type and closures (rust-lang/book#4244) - Edition maintenance: scripting the updates for future work (rust-lang/book#4243) - Ch. 17: fresh-eyes edits (rust-lang/book#4242) - Ch. 17: drop lifetime not required in 2024 Edition (rust-lang/book#4212) - Appendix B, Operators: Replace “member access” with “field access” and “method call”. (rust-lang/book#4240) - Update to Rust 1.85 and 2024 Edition! (rust-lang/book#4241) - Chapter 1: fix 'four things' now that spacing is not emphasized (rust-lang/book#4239) - Fix typos in chapter 17 (rust-lang/book#4238) - NoStarch backports (rust-lang/book#4224) - Fix example for `cargo fix` (rust-lang/book#4226) - Add missing word in ch17-04-streams.md (rust-lang/book#4218) - Fix typo in ch5.3 and in CONTRIBUTING.md (rust-lang/book#4216) - chore: reformat src with dprint (rust-lang/book#4211) - Redirects: get rid of the weird gap in Ch. 20 sections! (rust-lang/book#4209) - Document that `use` is also for `precise capturing` (rust-lang/book#4210) - Ch. 17: NoStarch Edits! (rust-lang/book#4206) ## rust-lang/nomicon 1 commits in 23fc2682f8fcb887f77d0eaabba708809f834c11..60f0b30d8ec1c9eb5c2582f2ec55f1094b0f8c42 2025-10-20 13:05:39 UTC to 2025-10-20 13:05:39 UTC - Fix typo in exception-safety.md (BinaryHeap::sift_up, user-defined and unsafe code separated) (rust-lang/nomicon#504) ## rust-lang/reference 11 commits in 8efb9805686722dba511b7b27281bb6b77d32130..752eab01cebdd6a2d90b53087298844c251859a1 2025-10-16 04:31:58 UTC to 2025-10-06 22:38:53 UTC - Clarify struct pattern binding shorthand (rust-lang/reference#2054) - Follow edition formatting for keywords (rust-lang/reference#2050) - generalise paragraph (rust-lang/reference#2047) - Rework the definitions of the extern ABIs (rust-lang/reference#2003) - Fix grammar of `ConstParam` (rust-lang/reference#2036) - Add a note to patterns.ident.precedent (rust-lang/reference#2022) - Add a description of how the reference is published (rust-lang/reference#2028) - Rearrange the README a little (rust-lang/reference#2029) - Consistently use sentence case (rust-lang/reference#2030) - More clearly define the default abi of an extern block (rust-lang/reference#2001) - fix(css): Correctly specify grammar-literal-bg (rust-lang/reference#2032)

rustc-dev-guide subtree update Subtree update of `rustc-dev-guide` to rust-lang/rustc-dev-guide@7cb1f42. Created using https://github.com/rust-lang/josh-sync. r? `@ghost`

Zalathar · 2025-10-21T01:21:16Z

Rollup of everything.

@bors r+ rollup=never p=5

bors · 2025-10-21T01:21:18Z

📌 Commit 866ed3a has been approved by Zalathar

It is now in the queue for this repository.

bors · 2025-10-21T04:28:58Z

⌛ Testing commit 866ed3a with merge e821cb8...

bors · 2025-10-21T07:40:23Z

☀️ Test successful - checks-actions
Approved by: Zalathar
Pushing e821cb8 to master...

rust-timer · 2025-10-21T07:41:52Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#147125	move `once` module out of `poison`	`a21365899a7576b19128b9d6cf5dfdd7111555df` (link)
#147800	Add `Cacheable` trait alias in `rustc_public_bridge`	`df568415020aa3f0ff2c79cd2682d1e9a2beadf4` (link)
#147860	rustdoc search: relax rules for identifiers	`b5798012f2f4535f6fdf2c36dcaea9842aa9287a` (link)
#147916	Update books	`14b469158583139c7d6ca244b5bd782a084de05a` (link)
#147924	rustc-dev-guide subtree update	`2be1a9edc2a8e01b32e6bee3f1b13ab5e2742f3d` (link)

previous master: 63dcdf7ca8

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-10-21T07:44:10Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 63dcdf7 (parent) -> e821cb8 (this PR)

Test differences

Show 66 test diffs

66 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard e821cb8dd94a01b8ad31d5d6d4a4b1a77a50a471 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

pr-check-1: 1743.6s -> 1453.0s (-16.7%)
x86_64-rust-for-linux: 3041.1s -> 2602.1s (-14.4%)
i686-gnu-1: 8383.8s -> 7226.3s (-13.8%)
aarch64-gnu-llvm-20-1: 3914.0s -> 3403.4s (-13.0%)
x86_64-gnu-llvm-20: 2759.7s -> 2413.3s (-12.6%)
aarch64-gnu-llvm-20-2: 2448.8s -> 2152.9s (-12.1%)
aarch64-gnu: 6920.8s -> 6135.2s (-11.4%)
dist-powerpc64le-linux-musl: 5295.9s -> 5837.2s (10.2%)
aarch64-msvc-2: 5060.2s -> 4584.5s (-9.4%)
x86_64-gnu-gcc: 3362.9s -> 3055.9s (-9.1%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-10-21T09:02:59Z

Finished benchmarking commit (e821cb8): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.1%	[0.1%, 0.1%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.3%, -0.3%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -7.7%, secondary -2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.8%	[2.4%, 3.0%]	3
Improvements ✅ (primary)	-7.7%	[-7.7%, -7.7%]	1
Improvements ✅ (secondary)	-4.0%	[-5.0%, -1.0%]	11
All ❌✅ (primary)	-7.7%	[-7.7%, -7.7%]	1

Cycles

Results (primary 2.4%, secondary 1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.4%	[2.2%, 2.7%]	3
Regressions ❌ (secondary)	4.4%	[1.6%, 9.3%]	9
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.9%	[-8.3%, -1.7%]	5
All ❌✅ (primary)	2.4%	[2.2%, 2.7%]	3

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 471.672s -> 472.699s (0.22%)
Artifact size: 388.66 MiB -> 390.70 MiB (0.52%)

Urgau and others added 29 commits October 6, 2025 19:20

Update to new S-waiting-on-compiler and I-compiler-nominated labels

2a0600e

name of the tool is lower case

957b415

Merge pull request rust-lang#2607 from rust-lang/tshepang-patch-5

1b5de6c

name of the tool is lower case

Remove outdated recurring work item

673fa83

Merge pull request rust-lang#2608 from jieyouxu/remove-outdated-issue

54d8bd4

Remove outdated recurring work item

Add t- prefix to S-waiting-on-compiler label

8a18afd

Merge pull request rust-lang#2606 from Urgau/waiting-on-team-refactor

d5c3b51

Update to new `S-waiting-on-compiler` and `I-compiler-nominated` labels

Add debug assertions flag to cg_gcc invocation

be95904

Merge pull request rust-lang#2609 from Kobzol/gcc-assertions

570d855

Add debug assertions flag to `cg_gcc` invocation

Building a fully-functional compiler requires x build library

e9560cb

Restore section "Faster builds with --keep-stage" as-is

455025c

Prefer --keep-stage-std for compiler rebuilds

3505f2c

Merge pull request rust-lang#2610 from Zalathar/build-library

16061dc

Fix and improve guidance for building/rebuilding the compiler

Overhaul GCC codegen backend section

5189a68

Merge pull request rust-lang#2611 from Kobzol/gcc-unify

581971b

Overhaul GCC codegen backend section

add Cacheable trait alias

5b28752

rename once::ExclusiveState to OnceExclusiveState

a61c8be

It is a bit confusing when reading code that uses this type since it is not immediately obvious that it is specific to `Once`. Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>

clean up some documentation

0758e19

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>

reorganize library/std/src/sync/mod.rs file

7b61403

Moves things around to make a bit more sense (plus prepare moving `once` out of `poison`. Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>

move once module out of poison

3a9c521

Since `Once` will not have a non-poisoning variant, we remove it from the `poison` module. Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>

Update books

67ec3ad

debugging.md: Remove wrong claim that LLVM bitcode is not the same as IR

578d06d

They are the same thing since they can be converted back and forth without loss.

rustdoc search: relax rules for identifiers

a354992

Merge pull request rust-lang#2613 from Enselic/bitcode

05d4da3

debugging.md: Remove wrong claim that LLVM bitcode is not the same as LLVM IR

Rollup merge of rust-lang#147800 - makai410:rp-cache-obj, r=celinval

8cd557d

Add `Cacheable` trait alias in `rustc_public_bridge` r? `@celinval`

Rollup merge of rust-lang#147860 - lolbinarycat:rustdoc-search-relax-…

68bcd90

…ident-rules, r=notriddle,GuillaumeGomez rustdoc search: relax rules for identifiers fixes rust-lang#147763

Rollup merge of rust-lang#147924 - tshepang:rdg-sync, r=tshepang

866ed3a

rustc-dev-guide subtree update Subtree update of `rustc-dev-guide` to rust-lang/rustc-dev-guide@7cb1f42. Created using https://github.com/rust-lang/josh-sync. r? `@ghost`

rustbot added the A-rustc-dev-guide Area: rustc-dev-guide label Oct 21, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 21, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 21, 2025

bors merged commit e821cb8 into rust-lang:master Oct 21, 2025
12 checks passed

rustbot added this to the 1.92.0 milestone Oct 21, 2025

Zalathar deleted the rollup-2lmpajs branch October 21, 2025 07:41

This was referenced Oct 21, 2025

Added get_unchecked and get_unchecked_mut to OnceLock and LazyLock #138914

Open

oneshot Channel #143741

Open

Add From impls for wrapper types #146013

Open

bors mentioned this pull request Oct 21, 2025

Simplify rustc_public context handling #147923

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 5 pull requests #147928

Rollup of 5 pull requests #147928

Uh oh!

Zalathar commented Oct 21, 2025 •

edited by rustbot

Loading

Uh oh!

Zalathar commented Oct 21, 2025

Uh oh!

bors commented Oct 21, 2025

Uh oh!

bors commented Oct 21, 2025

Uh oh!

bors commented Oct 21, 2025

Uh oh!

Uh oh!

rust-timer commented Oct 21, 2025

Uh oh!

github-actions bot commented Oct 21, 2025

Uh oh!

rust-timer commented Oct 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

Rollup of 5 pull requests #147928

Rollup of 5 pull requests #147928

Uh oh!

Conversation

Zalathar commented Oct 21, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zalathar commented Oct 21, 2025

Uh oh!

bors commented Oct 21, 2025

Uh oh!

bors commented Oct 21, 2025

Uh oh!

bors commented Oct 21, 2025

Uh oh!

Uh oh!

rust-timer commented Oct 21, 2025

Uh oh!

github-actions bot commented Oct 21, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Oct 21, 2025

Overall result: ❌✅ regressions and improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

Zalathar commented Oct 21, 2025 •

edited by rustbot

Loading