Skip to content

Improve diagnostics for buffer reuse with borrowed references #147974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve diagnostics for buffer reuse with borrowed references #147974

wants to merge 1 commit into from

Conversation

JohnTitor
Copy link
Member

@JohnTitor JohnTitor commented Oct 22, 2025 •
edited by rustbot
Loading

Fixes #147694

I'm not sure the current note wording is the best so I appreciate any feedback.

@rustbot
Copy link
Collaborator

rustbot commented Oct 22, 2025

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 22, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 22, 2025

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@JohnTitor
Copy link
Member Author

r? @estebank

@rustbot rustbot assigned estebank and unassigned jackh726 Oct 22, 2025
JohnTitor
JohnTitor commented Oct 22, 2025
View reviewed changes
compiler/rustc_borrowck/src/diagnostics/conflict_errors.rs
)
);
err.help(
"buffer reuse with borrowed references requires unsafe code or restructuring"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't mention recycle_vec as I'm not sure if using that crate is the most common solution here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@estebank estebank

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Detect attempt to reuse buffer with extended borrows

4 participants

@JohnTitor @rustbot @estebank @jackh726