Skip to content

Conversation

Muscraft
Copy link
Member

@Muscraft Muscraft commented Oct 22, 2025

This PR updates annotate-snippets to the latest version and updates the adapter code1 so that AnnotateSnippetEmitter's output matches HumanEmitter's output. If anyone would like to see the differences2 between AnnotateSnippetEmitter and HumanEmitter, I have a branch where AnnotateSnippetEmitter is used in place of HumanEmitter.

Footnotes

  1. A lot of the adapter code changes are based on code for HumanEmitter.

  2. Some of the test differences will go away when fix: Don't add diff symbol to unchanged lines #148001 and fix: Only special case single line item attribute suggestions #148004 are merged.

@rustbot
Copy link
Collaborator

rustbot commented Oct 22, 2025

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 22, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 22, 2025

r? @jdonszelmann

rustbot has assigned @jdonszelmann.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants