Skip to content

Add TidyFlags and merge DiagCtx #148017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add TidyFlags and merge DiagCtx #148017

wants to merge 1 commit into from
+171 −137

Conversation

simp4t7
Copy link
Contributor

@simp4t7 simp4t7 commented Oct 23, 2025

Adds a struct TidyFlags and merges it with DiagCtx into TidyCtx. Removes the need to pass bless into individual check functions in tidy.

@rustbot
Copy link
Collaborator

rustbot commented Oct 23, 2025

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @wesleywiser

tidy extra checks were modified.

cc @lolbinarycat

@rustbot rustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 23, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 23, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@simp4t7
Copy link
Contributor Author

simp4t7 commented Oct 23, 2025

r? @Kobzol

@rustbot rustbot assigned Kobzol and unassigned jieyouxu Oct 23, 2025
Kobzol
Kobzol reviewed Oct 23, 2025
View reviewed changes
Copy link
Member

@Kobzol Kobzol left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a nice cleanup. Left one nit.

View changes since this review

@simp4t7
add TidyFlags and merge DiagCtx
dbeb7fa 
reorder impl block

changed is_bless to is_bless_enabled
@Kobzol
Copy link
Member

Kobzol commented Oct 23, 2025

Thank you!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 23, 2025

📌 Commit dbeb7fa has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 23, 2025
@Zalathar
Rollup merge of rust-lang#148017 - simp4t7:add-tidy-flags, r=Kobzol
5ff30d3 
Add TidyFlags and merge DiagCtx

Adds a struct `TidyFlags` and merges it with `DiagCtx` into `TidyCtx`. Removes the need to pass `bless` into individual check functions in tidy.
@Zalathar Zalathar mentioned this pull request Oct 23, 2025
Open
bors added a commit that referenced this pull request Oct 23, 2025
@bors
Auto merge of #148022 - Zalathar:rollup-3m6ty9u, r=Zalathar
11d2046 
Rollup of 2 pull requests

Successful merges:

 - #140463 (Document MaybeUninit bit validity)
 - #148017 (Add TidyFlags and merge DiagCtx)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kobzol Kobzol Kobzol left review comments

Assignees

@Kobzol Kobzol

Labels

A-tidy Area: The tidy tool S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@simp4t7 @rustbot @Kobzol @bors @jieyouxu