Skip to content

Rollup of 2 pull requests #148022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 23, 2025
Merged

Rollup of 2 pull requests #148022

merged 5 commits into from
Oct 23, 2025
+254 −137

Conversation

@Zalathar
Copy link
Contributor

@Zalathar Zalathar commented Oct 23, 2025 •
edited by rustbot
Loading

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

joshlf and others added 5 commits September 21, 2025 04:29
@joshlf @RalfJung @traviscross
Document MaybeUninit bit validity
7971b2a 
Co-authored-by: Ralf Jung <post@ralfj.de>
Edited-by: TC
@traviscross
Revise MaybeUninit validity documentation
11627f0 
Let's rewrite this for better clarity.  In particular, let's document
our language guarantees upfront and in positive form.  We'll then list
the caveats and the non-guarantees after.
@simp4t7
add TidyFlags and merge DiagCtx
dbeb7fa 
reorder impl block

changed is_bless to is_bless_enabled
@Zalathar
Rollup merge of rust-lang#140463 - joshlf:patch-13, r=RalfJung
c5e4a5f 
Document MaybeUninit bit validity

Partially addresses rust-lang/unsafe-code-guidelines#555 by clarifying that it is sound to write any byte values (initialized or uninitialized) to any `MaybeUninit<T>` regardless of `T`.

r? `@RalfJung`
@Zalathar
Rollup merge of rust-lang#148017 - simp4t7:add-tidy-flags, r=Kobzol
5ff30d3 
Add TidyFlags and merge DiagCtx

Adds a struct `TidyFlags` and merges it with `DiagCtx` into `TidyCtx`. Removes the need to pass `bless` into individual check functions in tidy.
@rustbot rustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Oct 23, 2025
@Zalathar
Copy link
Contributor Author

Rollup of everything not in #148014.

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Oct 23, 2025

📌 Commit 5ff30d3 has been approved by Zalathar

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2025
@bors
Copy link
Collaborator

bors commented Oct 23, 2025

⌛ Testing commit 5ff30d3 with merge 11d2046...

@bors
Copy link
Collaborator

bors commented Oct 23, 2025

☀️ Test successful - checks-actions
Approved by: Zalathar
Pushing 11d2046 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 23, 2025
@bors bors merged commit 11d2046 into rust-lang:master Oct 23, 2025
12 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 23, 2025
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#140463 Document MaybeUninit bit validity 41f21b40a0062dea51fc0993001b723499c6f607 (link)
#148017 Add TidyFlags and merge DiagCtx a8f2ac052078ab066dcb35489f0a6f9a92d415a9 (link)

previous master: 469357eb48

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 469357e (parent) -> 11d2046 (this PR)

Test differences

Show 160 test diffs

160 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 11d2046fe9962720558cb15f72541f7fd170dec9 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-gnu-llvm-20-2: 2576.2s -> 2164.0s (-16.0%)
  2. dist-x86_64-apple: 8250.5s -> 7072.6s (-14.3%)
  3. aarch64-gnu-llvm-20-1: 4003.6s -> 3433.6s (-14.2%)
  4. i686-gnu-2: 6364.5s -> 5554.2s (-12.7%)
  5. dist-aarch64-apple: 7136.7s -> 6319.1s (-11.5%)
  6. x86_64-gnu-gcc: 3462.7s -> 3071.2s (-11.3%)
  7. x86_64-gnu-llvm-20: 2726.5s -> 2449.4s (-10.2%)
  8. x86_64-gnu-miri: 4797.9s -> 4332.9s (-9.7%)
  9. x86_64-rust-for-linux: 2980.6s -> 2693.4s (-9.6%)
  10. x86_64-gnu-tools: 3597.2s -> 3267.6s (-9.2%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (11d2046): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.1% [-0.1%, -0.1%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.5% [1.7%, 5.6%] 11
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.4% [-2.4%, -2.4%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.879s -> 474.995s (0.02%)
Artifact size: 390.43 MiB -> 390.51 MiB (0.02%)

@Zalathar Zalathar deleted the rollup-3m6ty9u branch October 23, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-tidy Area: The tidy tool merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

7 participants

@Zalathar @bors @rust-timer @rustbot @joshlf @traviscross @simp4t7