[rustdoc] Simplify module rendering and HTML tags handling

[GuillaumeGomez]

Extracted code from #145458.

This PR simplifies the rendering of modules, in particular the HTML tags handling. Instead of having all items in a vec, we make a map with their types as key, allowing to then iterate over the types, which allows us to open and close the HTML tag at every turn without the need to check if a tag was opened or not, or to check it's still the same kind of type.

For a better review experience: enable "Hide whitespace", the diff will be much smaller.

r? @notriddle

[GuillaumeGomez]

I don't think it will have an impact on perf but just in case...

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: 3f89e8c (3f89e8c7d52cf4f9ef2b3c80fdf72fd74c5591e9, parent: 4b3ba5844e8831c9b3ee5a5643cdff5da0677426)

[rust-timer]

Finished benchmarking commit (3f89e8c): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.3%, -0.1%]	11
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 2.3%, secondary -4.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.3%	[2.3%, 2.3%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.1%	[-4.1%, -4.1%]	2
All ❌✅ (primary)	2.3%	[2.3%, 2.3%]	1

Cycles

Results (secondary 2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.933s -> 474.295s (-0.13%)
Artifact size: 390.48 MiB -> 390.52 MiB (0.01%)

[GuillaumeGomez]

Close to no changes, so all good. :)

[notriddle]

If you use FxIndexMap instead, does that have any effect on the perf? That would let you get rid of all the query instability annotations.

[GuillaumeGomez]

Worth a try!

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: d7aa67f (d7aa67f4fc78ade7b7f4667eafddc1d5bc265377, parent: 6501e64fcb02d22b49d6e59d10a7692ec8095619)

[rust-timer]

Finished benchmarking commit (d7aa67f): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 4.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.6%	[4.6%, 4.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary -6.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-6.0%	[-6.0%, -6.0%]	1
All ❌✅ (primary)	-	-	0

Binary size

Results (secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	1
All ❌✅ (primary)	-	-	0

Bootstrap: 476.496s -> 477.411s (0.19%)
Artifact size: 390.49 MiB -> 390.50 MiB (0.00%)

[notriddle]

@bors r+ rollup

[bors]

📌 Commit 90c047b has been approved by notriddle

It is now in the queue for this repository.

[Zalathar]

Bors hasn't noticed that this was merged.

@bors r-