Rollup of 5 pull requests #148059

Zalathar · 2025-10-24T03:53:49Z

Successful merges:

Revert constification of Borrow and Deref for Cow due to inference failure #148016 (Revert constification of Borrow and Deref for Cow due to inference failure)
[rustdoc] Simplify module rendering and HTML tags handling #148021 ([rustdoc] Simplify module rendering and HTML tags handling)
Add myself to the review rotation #148039 (Add myself to the review rotation)
test(frontmatter): Cover spaces between infostring parts #148042 (test(frontmatter): Cover spaces between infostring parts)
Streamline iterator chaining when computing successors. #148054 (Streamline iterator chaining when computing successors.)

r? @ghost
@rustbot modify labels: rollup

As these characters are specifically called out in the RFC, I felt it would be important to have a test to cover them.

There are numerous unnecessary `into_iter` calls. Also add a comment explaining why the code looks like this, because it's non-obvious at first glance.

…, r=cuviper Revert constification of `Borrow` and `Deref for Cow` due to inference failure Reported issue: rust-lang#147964 Original PR: rust-lang#145279 Previous revert: rust-lang#148011 `const Borrow`/`Deref` tracking issue: rust-lang#143773 Should have additional crater run to verify this fixes the issue. Since other PR is in the queue, this will need to be rebased after that merges. Also will want a beta nomination.

…, r=notriddle [rustdoc] Simplify module rendering and HTML tags handling Extracted code from rust-lang#145458. This PR simplifies the rendering of modules, in particular the HTML tags handling. Instead of having all items in a `vec`, we make a map with their types as key, allowing to then iterate over the types, which allows us to open and close the HTML tag at every turn without the need to check if a tag was opened or not, or to check it's still the same kind of type. For a better review experience: enable "Hide whitespace", the diff will be much smaller. r? `@notriddle`

…thanBrouwer Add myself to the review rotation

test(frontmatter): Cover spaces between infostring parts As these characters are specifically called out in the RFC, I felt it would be important to have a test to cover them. Tracking issue: rust-lang#136889

Streamline iterator chaining when computing successors. There are numerous unnecessary `into_iter` calls. Also add a comment explaining why the code looks like this, because it's non-obvious at first glance. r? `@saethlin`

Zalathar · 2025-10-24T03:54:00Z

Rollup of everything.

@bors r+ rollup=never p=5

bors · 2025-10-24T03:54:05Z

📌 Commit 7141a0f has been approved by Zalathar

It is now in the queue for this repository.

Zalathar · 2025-10-24T03:55:16Z

Watch out for a failure in x86_64-mingw-1 tests\run-make\share-generics-export-again, in case #148055 (comment) turns out to be real and not flaky.

bors · 2025-10-24T06:27:14Z

⌛ Testing commit 7141a0f with merge 75948c8...

bors · 2025-10-24T09:34:14Z

☀️ Test successful - checks-actions
Approved by: Zalathar
Pushing 75948c8 to master...

rust-timer · 2025-10-24T09:35:42Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#148016	Revert constification of `Borrow` and `Deref for Cow` due t…	`b2e231a8ea7f4d3943fc66061c31113a0ce69dc2` (link)
#148021	[rustdoc] Simplify module rendering and HTML tags handling	`993c74219086ff7466ba3c62598e7ff6181404e3` (link)
#148039	Add myself to the review rotation	`6d6cea908ed72b1b03c6e961274f3b46afdc4640` (link)
#148042	test(frontmatter): Cover spaces between infostring parts	`8318dfe98e6fe9933259753a0b524a12d0378f42` (link)
#148054	Streamline iterator chaining when computing successors.	`42baff82f47687afefbba2e2abe8549404a62377` (link)

previous master: 38bc2468de

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-10-24T09:37:46Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 38bc246 (parent) -> 75948c8 (this PR)

Test differences

Show 42 test diffs

Stage 1

[ui] tests/ui/frontmatter/space-in-infostring.rs: [missing] -> pass (J0)
[ui] tests/ui/traits/generic-cow-inference-regression.rs: [missing] -> pass (J0)

Stage 2

[ui] tests/ui/frontmatter/space-in-infostring.rs: [missing] -> pass (J1)
[ui] tests/ui/traits/generic-cow-inference-regression.rs: [missing] -> pass (J1)

Additionally, 38 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 75948c8bb3bd37f1e8ee20273a04edea4c1f84f8 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-gnu-llvm-20: 2423.3s -> 2849.0s (17.6%)
pr-check-2: 2277.1s -> 2620.3s (15.1%)
aarch64-msvc-1: 6475.3s -> 7362.4s (13.7%)
x86_64-msvc-ext2: 5348.5s -> 6025.2s (12.7%)
x86_64-rust-for-linux: 2578.0s -> 2883.6s (11.9%)
aarch64-apple: 8247.9s -> 9147.4s (10.9%)
dist-apple-various: 3617.9s -> 3228.0s (-10.8%)
aarch64-gnu-debug: 3705.8s -> 4063.3s (9.6%)
armhf-gnu: 4869.4s -> 5315.3s (9.2%)
x86_64-gnu-tools: 3383.4s -> 3690.9s (9.1%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-10-24T10:44:23Z

Finished benchmarking commit (75948c8): comparison URL.

Overall result: ❌ regressions - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.1%, 0.4%]	35
Regressions ❌ (secondary)	0.2%	[0.0%, 1.5%]	34
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[0.1%, 0.4%]	35

Max RSS (memory usage)

Results (primary 0.2%, secondary -2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.1%	[1.1%, 1.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.8%	[-0.8%, -0.8%]	1
Improvements ✅ (secondary)	-2.2%	[-2.2%, -2.2%]	1
All ❌✅ (primary)	0.2%	[-0.8%, 1.1%]	2

Cycles

Results (secondary -1.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.7%	[4.7%, 4.7%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.7%	[-3.5%, -1.5%]	8
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 473.974s -> 474.959s (0.21%)
Artifact size: 390.47 MiB -> 390.49 MiB (0.00%)

Zalathar · 2025-10-24T11:01:30Z

Streamline iterator chaining when computing successors. #148054

@rust-timer build 42baff8

lqd · 2025-10-24T11:02:28Z

Such weird results. It's got to be noise, I hope :)

rust-timer · 2025-10-24T12:55:39Z

Finished benchmarking commit (42baff8): comparison URL.

Overall result: ❌ regressions - please read the text below

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.1%, 0.4%]	37
Regressions ❌ (secondary)	0.2%	[0.0%, 1.3%]	27
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.2%]	1
All ❌✅ (primary)	0.1%	[0.1%, 0.4%]	37

Max RSS (memory usage)

Results (primary -0.5%, secondary -2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.5%	[-0.5%, -0.5%]	1
Improvements ✅ (secondary)	-2.0%	[-2.0%, -2.0%]	1
All ❌✅ (primary)	-0.5%	[-0.5%, -0.5%]	1

Cycles

Results (primary -2.0%, secondary 3.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.6%	[2.0%, 5.1%]	2
Improvements ✅ (primary)	-2.0%	[-2.0%, -2.0%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.0%	[-2.0%, -2.0%]	1

Binary size

Results (secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Bootstrap: 473.974s -> 475.828s (0.39%)
Artifact size: 390.47 MiB -> 390.45 MiB (-0.01%)

Zalathar · 2025-10-24T13:12:12Z

Revert constification of Borrow and Deref for Cow due to inference failure #148016

@rust-timer build b2e231a

rust-timer · 2025-10-24T16:23:06Z

Finished benchmarking commit (b2e231a): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.1%	[0.1%, 0.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	2
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 0.2%, secondary -2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.1%	[1.1%, 1.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.7%	[-0.7%, -0.7%]	1
Improvements ✅ (secondary)	-2.7%	[-2.7%, -2.7%]	1
All ❌✅ (primary)	0.2%	[-0.7%, 1.1%]	2

Cycles

Results (secondary -3.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.4%	[-5.7%, -1.8%]	10
All ❌✅ (primary)	-	-	0

Binary size

Results (secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Bootstrap: 473.974s -> 475.912s (0.41%)
Artifact size: 390.47 MiB -> 390.49 MiB (0.01%)

GuillaumeGomez and others added 12 commits October 23, 2025 12:59

[rustdoc] Simplify module rendering and HTML tags handling

c18cd77

Revert inference failure from Deref/Borrow constification

ebd5bea

Add myself to the review rotation

9ceb997

test(frontmatter): Cover spaces between infostring parts

bca35ef

As these characters are specifically called out in the RFC, I felt it would be important to have a test to cover them.

Replace the FxHashMap with an FxIndexMap

90c047b

Streamline iterator chaining when computing successors.

3d95159

There are numerous unnecessary `into_iter` calls. Also add a comment explaining why the code looks like this, because it's non-obvious at first glance.

Add regression test for inference failures

4a4f3b0

Rollup merge of rust-lang#148039 - JonathanBrouwer:add-myself, r=Jona…

439d374

…thanBrouwer Add myself to the review rotation

Rollup merge of rust-lang#148042 - epage:info-space, r=Urgau

1958155

test(frontmatter): Cover spaces between infostring parts As these characters are specifically called out in the RFC, I felt it would be important to have a test to cover them. Tracking issue: rust-lang#136889

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 24, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 24, 2025

bors merged commit 75948c8 into rust-lang:master Oct 24, 2025
12 checks passed

rustbot added this to the 1.92.0 milestone Oct 24, 2025

Zalathar deleted the rollup-zkk5prm branch October 24, 2025 09:36

rustbot added the perf-regression Performance regression. label Oct 24, 2025

This comment has been minimized.

Sign in to view

Zalathar mentioned this pull request Oct 24, 2025

Streamline iterator chaining when computing successors. #148054

Merged

Rollup of 5 pull requests #148059

Rollup of 5 pull requests #148059

Conversation

Zalathar commented Oct 24, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zalathar commented Oct 24, 2025

Uh oh!

bors commented Oct 24, 2025

Uh oh!

Zalathar commented Oct 24, 2025

Uh oh!

bors commented Oct 24, 2025

Uh oh!

bors commented Oct 24, 2025

Uh oh!

Uh oh!

rust-timer commented Oct 24, 2025

Uh oh!

github-actions bot commented Oct 24, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Oct 24, 2025

Overall result: ❌ regressions - please read the text below

Uh oh!

Zalathar commented Oct 24, 2025

Uh oh!

This comment has been minimized.

lqd commented Oct 24, 2025

Uh oh!

rust-timer commented Oct 24, 2025

Overall result: ❌ regressions - please read the text below

Uh oh!

Zalathar commented Oct 24, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Oct 24, 2025

Overall result: ❌✅ regressions and improvements - no action needed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Zalathar commented Oct 24, 2025 •

edited by rustbot

Loading