Skip to content

Conversation

@Zalathar
Copy link
Member

@Zalathar Zalathar commented Oct 26, 2025

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

thaliaarchi and others added 6 commits September 11, 2025 19:50
…ss35

Make `IoSlice` and `IoSliceMut` methods unstably const

This enables constructing `IoSlice` and `IoSliceMut` in const contexts without users needing to break the platform abstraction by doing the cast themselves. This is useful for statics.

Since all current and plausible future platforms use simple slice-like structs, this should not impose a burden when adding a new platform with a different struct.
Don't require `T: RefUnwindSafe` for `vec::IntoIter<T>: UnwindSafe`

Closes rust-lang#144707

r? t-libs-api
…float_tests, r=tgross35

Unify and deduplicate max recip float tests

cc rust-lang#141726

This is a proposal to unify and deduplicate max recip tests for f16 and f128
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Oct 26, 2025
@Zalathar
Copy link
Member Author

Rollup of everything.

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Oct 26, 2025

📌 Commit 420214a has been approved by Zalathar

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2025
@bors
Copy link
Collaborator

bors commented Oct 26, 2025

⌛ Testing commit 420214a with merge b74c1e7...

bors added a commit that referenced this pull request Oct 26, 2025
Rollup of 3 pull requests

Successful merges:

 - #144090 (Make `IoSlice` and `IoSliceMut` methods unstably const)
 - #145665 (Don't require `T: RefUnwindSafe` for `vec::IntoIter<T>: UnwindSafe`)
 - #147818 (Unify and deduplicate max recip float tests)

r? `@ghost`
`@rustbot` modify labels: rollup
@rust-log-analyzer
Copy link
Collaborator

The job dist-various-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[RUSTC-TIMING] gimli test:false 4.126
[RUSTC-TIMING] object test:false 6.052
warning: dropping unsupported crate type `dylib` for target `wasm32-unknown-unknown`

error: const function that might be (indirectly) exposed to stable cannot use `#[feature(const_trait_impl)]`
  --> library/std/src/sys/io/io_slice/unsupported.rs:14:25
   |
14 |         self.0 = &self.0[n..]
   |                         ^^^^^
   |
help: if the function is not (yet) meant to be exposed to stable const contexts, add `#[rustc_const_unstable]`
   |
13 +     #[rustc_const_unstable(feature = "...", issue = "...")]
14 |     pub const fn advance(&mut self, n: usize) {
   |

error: `Index` is not yet stable as a const trait
  --> library/std/src/sys/io/io_slice/unsupported.rs:14:25
   |
14 |         self.0 = &self.0[n..]
   |                         ^^^^^
   |
help: add `#![feature(const_index)]` to the crate attributes to enable
  --> library/std/src/lib.rs:426:1
   |
426+ #![feature(const_index)]
   |

error[E0015]: cannot call non-const function `core::mem::take::<&mut [u8]>` in constant functions
  --> library/std/src/sys/io/io_slice/unsupported.rs:33:21
   |
33 |         let slice = mem::take(&mut self.0);
   |                     ^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: calls in constant functions are limited to constant functions, tuple structs and tuple variants

For more information about this error, try `rustc --explain E0015`.

@bors
Copy link
Collaborator

bors commented Oct 26, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 26, 2025
@Zalathar Zalathar closed this Oct 26, 2025
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 26, 2025
@Zalathar Zalathar deleted the rollup-xzrn9a0 branch October 26, 2025 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rollup A PR which is a rollup T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants