-
Notifications
You must be signed in to change notification settings - Fork 13.9k
Rollup of 4 pull requests #148123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Rollup of 4 pull requests #148123
+32
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n.rs` In 9253e12 a bunch of `gdbr-check` (for `rust-gdb`) and `gdbg-check` (for plain `gdb`) was added. But in two places the author accidentally wrote `gdbt-check` instead. This commit fixes this typo.
Don't require `T: RefUnwindSafe` for `vec::IntoIter<T>: UnwindSafe` Closes rust-lang#144707 r? t-libs-api
tests: activate misspelled `gdb-check` in `function-arg-initialization.rs` In 9253e12 a bunch of `gdbr-check` (for `rust-gdb`) directives and `gdbg-check` (for plain `gdb`) directives were added. But in two places the author accidentally wrote `gdbt-check` instead (`t` is next to `r` on the keyboard). This commit fixes that typo. rust-lang#129218 later renamed `gdbr-check` to just `gdb-check` which is why we rename to `gdb-check` directly. The test still passes locally for me after the change, but fails if I change the `gdb-check` checks to check for some other string, so the check seems to still perform its intended function. Note that we need to add a `std::hint::black_box()` to avoid $4 = <optimized out> prints on at least `aarch64-gnu-llvm-20-1`. After this there are no more instances of the string `gdbt` in the code base: ```console $ git grep gdbt ```
…lathar tests/debuginfo/closures.rs: Activate misspelled `cdb-check` Split out from rust-lang#147799 because these seemingly simple corrections can turn out to be non-trivial. See rust-lang#147728 for example.
…ug-msg, r=Noratrieb,dianqk Improve the ICE message for invalid nullary intrinsic calls In rust-lang#148104, we found the panic message here rather confusing, and (if I'm reading the tea leaves right) that's because the intended audience for either side of the phrase is very different. I think this is more clear if/when this is encountered by users. I expect this ICE to be hit in practice by people calling the `size_of` and `align_of` intrinsics, so it's now _kind of_ helpful for those users too. The original effort to stop backends from needing to support nullary intrinsics added a note to all these const-only intrinsics, but when rust-lang#147793 ported two more the paragraph wasn't added. I've added it.
|
Rollup of everything. @bors r+ rollup=never p=5 |
bors
added a commit
that referenced
this pull request
Oct 26, 2025
Rollup of 4 pull requests Successful merges: - #145665 (Don't require `T: RefUnwindSafe` for `vec::IntoIter<T>: UnwindSafe`) - #147728 (tests: activate misspelled `gdb-check` in `function-arg-initialization.rs`) - #148097 (tests/debuginfo/closures.rs: Activate misspelled `cdb-check`) - #148118 (Improve the ICE message for invalid nullary intrinsic calls) r? `@ghost` `@rustbot` modify labels: rollup
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rollup
A PR which is a rollup
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
T: RefUnwindSafeforvec::IntoIter<T>: UnwindSafe#145665 (Don't requireT: RefUnwindSafeforvec::IntoIter<T>: UnwindSafe)gdb-checkinfunction-arg-initialization.rs#147728 (tests: activate misspelledgdb-checkinfunction-arg-initialization.rs)cdb-check#148097 (tests/debuginfo/closures.rs: Activate misspelledcdb-check)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup