compiletest: Remove cleanup_debug_info_options
#148194
Conversation
This "cleanup" function is more than a decade old, and I can't find any evidence of modern-day bootstrap being able to pass any of these flags to `--host-rustcflags` or `--target-rustcflags`.
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
rustbot
added
A-compiletest
|
|
|
Some relevant ancient commits introducing the removed code: |
|
@bors try jobs=x86_64-msvc-1,i686-msvc-1,aarch64-msvc-1,x86_64-mingw-1,test-various,armhf-gnu,aarch64-apple |
This comment has been minimized.
This comment has been minimized.
compiletest: Remove `cleanup_debug_info_options` try-job: x86_64-msvc-1 try-job: i686-msvc-1 try-job: aarch64-msvc-1 try-job: x86_64-mingw-1 try-job: test-various try-job: armhf-gnu try-job: aarch64-apple
I have a few more compiletest PRs that I plan to open (big and small), so I understand if it takes some time to get around to all of them. Thanks for your good work! 💖 |
Yeah that is perfectly fine, it'll just take some time for me to get through them. |
3 participants
This "cleanup" function is more than a decade old, and I can't find any evidence of modern-day bootstrap being able to pass any of these flags to
--host-rustcflagsor--target-rustcflags.I thought about replacing the cleanup with an assertion, but I think it's better to delete it entirely for now, and re-add checks later if they're motivated by actual problems in practice.
In addition to deleting some old and confusing code, this also lets us remove three instances of duplicating
TestCx, which is the biggest win.r? jieyouxu