Skip to content

Fix deferred cast checks using the wrong body for determining constness #148287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix deferred cast checks using the wrong body for determining constness #148287

wants to merge 2 commits into from
+11 −3

Conversation

@oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Oct 30, 2025 •
edited
Loading

re-introduces #103683

it was lost in 4fec845

deferred checks possibly have more such issues, needs investigation.

r? @fee1-dead

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 30, 2025
@rustbot

This comment was marked as outdated.

Sign in to view
@rustbot rustbot assigned fee1-dead and unassigned jackh726 Oct 30, 2025
fee1-dead
fee1-dead requested changes Oct 30, 2025
View reviewed changes
Copy link
Member

@fee1-dead fee1-dead left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after

View changes since this review

compiler/rustc_hir_typeck/src/fn_ctxt/checks.rs
Comment on lines 75 to 76
// don't hold the borrow to deferred_cast_checks while checking to avoid borrow checker errors
// when writing to `self.param_env`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be outdated now; also do we still need to mem::take?

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fee1-dead fee1-dead fee1-dead requested changes

Assignees

@fee1-dead fee1-dead

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@oli-obk @rustbot @fee1-dead @jackh726