Skip to content

Allow check builds with binaries for the dummy codegen backend #148299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow check builds with binaries for the dummy codegen backend #148299

wants to merge 1 commit into from
+1 −0

Conversation

@bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Oct 30, 2025

This is likely the last part necessary for rust-lang/miri#4648. Miri needs to be able to do a regular check build for compile_fail doc tests to work.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 30, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 30, 2025

r? @SparrowLii

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@bjorn3 bjorn3 mentioned this pull request Oct 30, 2025
Draft
jieyouxu
jieyouxu approved these changes Oct 30, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

View changes since this review

@jieyouxu
Copy link
Member

You can r=me once PR CI is green.
r? jieyouxu

@rustbot rustbot assigned jieyouxu and unassigned SparrowLii Oct 30, 2025
@bjorn3
Copy link
Member Author

bjorn3 commented Oct 30, 2025

@bors r=jieyouxu

@bors
Copy link
Collaborator

bors commented Oct 30, 2025

📌 Commit 4b9dc49 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2025
bors added a commit that referenced this pull request Oct 30, 2025
@bors
Auto merge of #148299 - bjorn3:dummy_backend_check_builds, r=jieyouxu
d5419f1 
Allow check builds with binaries for the dummy codegen backend

This is likely the last part necessary for rust-lang/miri#4648. Miri needs to be able to do a regular check build for compile_fail doc tests to work.
@bors
Copy link
Collaborator

bors commented Oct 30, 2025

⌛ Testing commit 4b9dc49 with merge d5419f1...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bjorn3 @rustbot @jieyouxu @bors @SparrowLii