Fix wasm_import_module attribute cross-crate

[alexcrichton]

This commit fixes an accidental regression from #144678 where wasm targets would now accidentally use the wrong import module map for a symbol causing a symbol to skip mangling. This can result in compilation failures when symbols are used in cross-crate situations.

Closes #148347

[rustbot]

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[posborne]

I built this and verified that it now works as expected for both the smaller examples shared as well as for some larger projects that had previously encountered a large number of linker errors.

[alexcrichton]

It looks like we found some more issues as a result of this bug, namely a runtime issue so this isn't just a build failure. Given that I'd like to propose this get backported to beta at least, so I'm going to attempt to beta nominate this. Haven't done this in awhile...

@rustbot beta-nominate compiler

This is not something I'd ask for a stable backport of, but if a stable point release is already going out I wouldn't mind trying to champion trying to get this in there. I'll sort that out if/when this is accepted for a beta backport.

[rustbot]

Error: The feature nominate is not enabled in this repository.
To enable it add its section in the triagebot.toml in the root of the repository.

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip.

[alexcrichton]

I've probably abused my priviledges and manually added the label here, please teach me the error of my ways if that is uncouth.

[jieyouxu]

I've probably abused my priviledges and manually added the label here, please teach me the error of my ways if that is uncouth.

(This is perfectly fine, the triagebot invocation is just @rustbot label +beta-nominated, or since you have write permissions, you can just add a label like you did :) This will create a beta-backport nomination zulip thread #t-compiler/backports > #148363: beta-nominated where compiler team members can vote or discuss. They will be discussed during the next compiler triage meeting. This is obviously still being experimented with to see if we can make it smoother.)

[alexcrichton]

@rustbot label +stable-nominated

Some discussion at #t-compiler/backports > #148363: beta-nominated @ 💬 and it sounds like it's ok to tag this as stable-nominated but also to be clear that this alone, in my opinion, doesn't justify a point release on its own. If one's already going out I think this would be reasonable to include, however.

[jackh726]

@bors r+

[bors]

📌 Commit 93fef45 has been approved by jackh726

It is now in the queue for this repository.

[wesleywiser]

@bors p=1

Fixes high-priority issue, beta and stable backport nominated PR