-
Notifications
You must be signed in to change notification settings - Fork 13.9k
rust-analyzer subtree update
#148471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rust-analyzer subtree update
#148471
Conversation
Example
---
```rust
fn main() {
let mut x = Some(1);
while x.is_som$0e() { x = None }
}
```
**Before this PR**
Assist not applicable
**After this PR**
```rust
fn main() {
let mut x = Some(1);
while let Some(${0:x1}) = x { x = None }
}
```
By letting the solver take control of them (reveal them when needed and define them when needed), by providing them in the `TypingMode` plus few helpers.
… syntax to assoc fn syntax
feat: When renaming `self` to other name, change callers method method call syntax to assoc fn syntax
…y-flyimport fix: Consider all matches for flyimport even when searched with a qualifier
…feature(specialization)]` To save memory.
…n-ns2 Avoid calling `specializes()` query on crates that do not define `#![feature(specialization)]`
…ozkq perf: Reduce `client_commands` allocations in proto conversion
…tations" or "Implementations" codelens I don't do it by default, for three reasons: (1) it's more expensive, (2) I actually quite like seeing the derives, and they may expand to no impl/more than one impl, (3) if rust-lang#19130 will ever be merged this will become even more useful. Even a config might be too much, but it was fun and easy to code so I did that.
…derive feat: Provide an option to not show derives near the ADT for "Goto Implementations" or "Implementations" codelens
…-let Fix not applicable on while for replace_is_method_with_if_let_method
fix: Properly support opaques
Unfortunately, this requires a custom build of r-a, and it's quite slow.
…lock fix: Fix handling of blocks modules that are not the root module
Co-authored-by: Lukas Wirth <lukas@zed.dev>
Show proper async function signatures in the signature help
…ntpo fix: Improve error recovery when parsing malformed function return types
minor: Cleanup `map_rust_child_diagnostics` a bit
fix: Do not make false positive syntax errors on frontmatter
Fix typos, backtick errors/omissions
feat: Support memory profiling with dhat
fix: Expand literals with wrong suffixes into `LitKind::Err`
Add more expression to 'in_value'
Convert for each range into while loop.
```rust
fn foo() {
$0for i in 3..7 {
foo(i);
}
}
```
->
```rust
fn foo() {
let mut i = 3;
while i < 7 {
foo(i);
i += 1;
}
}
```
Add ide-assist: convert_range_for_to_while
minor: Fix test name
minor: Rustc pull update
|
rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer |
|
|
@bors r+ p=1 subtree sync |
`rust-analyzer` subtree update Subtree update of `rust-analyzer` to rust-lang/rust-analyzer@51af7a3. Created using https://github.com/rust-lang/josh-sync. r? ``@ghost``
`rust-analyzer` subtree update Subtree update of `rust-analyzer` to rust-lang/rust-analyzer@51af7a3. Created using https://github.com/rust-lang/josh-sync. r? `@ghost`
|
@bors retry |
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing e5efc33 (parent) -> f15a7f3 (this PR) Test differencesShow 2 test diffs2 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard f15a7f38580ddbdc1a23909dd05cf6cc6d9f3919 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (f15a7f3): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (primary 1.9%, secondary 2.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 473.413s -> 474.825s (0.30%) |
Subtree update of
rust-analyzerto rust-lang/rust-analyzer@51af7a3.Created using https://github.com/rust-lang/josh-sync.
r? @ghost