Skip to content

Conversation

@lnicola
Copy link
Member

@lnicola lnicola commented Nov 4, 2025

Subtree update of rust-analyzer to rust-lang/rust-analyzer@51af7a3.

Created using https://github.com/rust-lang/josh-sync.

r? @ghost

A4-Tacks and others added 30 commits October 27, 2025 15:30
Example
---
```rust
fn main() {
    let mut x = Some(1);
    while x.is_som$0e() { x = None }
}
```

**Before this PR**

Assist not applicable

**After this PR**

```rust
fn main() {
    let mut x = Some(1);
    while let Some(${0:x1}) = x { x = None }
}
```
By letting the solver take control of them (reveal them when needed and define them when needed), by providing them in the `TypingMode` plus few helpers.
feat: When renaming `self` to other name, change callers method method call syntax to assoc fn syntax
…y-flyimport

fix: Consider all matches for flyimport even when searched with a qualifier
…n-ns2

Avoid calling `specializes()` query on crates that do not define `#![feature(specialization)]`
…ozkq

perf: Reduce `client_commands` allocations in proto conversion
…tations" or "Implementations" codelens

I don't do it by default, for three reasons: (1) it's more expensive, (2) I actually quite like seeing the derives, and they may expand to no impl/more than one impl, (3) if rust-lang#19130 will ever be merged this will become even more useful.

Even a config might be too much, but it was fun and easy to code so I did that.
…derive

feat: Provide an option to not show derives near the ADT for "Goto Implementations" or "Implementations" codelens
…-let

Fix not applicable on while for replace_is_method_with_if_let_method
Unfortunately, this requires a custom build of r-a, and it's quite slow.
…lock

fix: Fix handling of blocks modules that are not the root module
Co-authored-by: Lukas Wirth <lukas@zed.dev>
Show proper async function signatures in the signature help
…ntpo

fix: Improve error recovery when parsing malformed function return types
minor: Cleanup `map_rust_child_diagnostics` a bit
fix: Do not make false positive syntax errors on frontmatter
Fix typos, backtick errors/omissions
feat: Support memory profiling with dhat
Veykril and others added 9 commits November 3, 2025 20:18
fix: Expand literals with wrong suffixes into `LitKind::Err`
Convert for each range into while loop.

```rust
fn foo() {
    $0for i in 3..7 {
        foo(i);
    }
}
```
->
```rust
fn foo() {
    let mut i = 3;
    while i < 7 {
        foo(i);
        i += 1;
    }
}
```
@rustbot
Copy link
Collaborator

rustbot commented Nov 4, 2025

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue. labels Nov 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 4, 2025

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

@lnicola
Copy link
Member Author

lnicola commented Nov 4, 2025

@bors r+ p=1 subtree sync

@bors
Copy link
Collaborator

bors commented Nov 4, 2025

📌 Commit 5873327 has been approved by lnicola

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 4, 2025
`rust-analyzer` subtree update

Subtree update of `rust-analyzer` to rust-lang/rust-analyzer@51af7a3.

Created using https://github.com/rust-lang/josh-sync.

r? ``@ghost``
@bors
Copy link
Collaborator

bors commented Nov 4, 2025

⌛ Testing commit 5873327 with merge b881edc...

bors added a commit that referenced this pull request Nov 4, 2025
`rust-analyzer` subtree update

Subtree update of `rust-analyzer` to rust-lang/rust-analyzer@51af7a3.

Created using https://github.com/rust-lang/josh-sync.

r? `@ghost`
@matthiaskrgr
Copy link
Member

@bors retry

@bors
Copy link
Collaborator

bors commented Nov 4, 2025

⌛ Testing commit 5873327 with merge f15a7f3...

@bors
Copy link
Collaborator

bors commented Nov 4, 2025

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing f15a7f3 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 4, 2025
@bors bors merged commit f15a7f3 into rust-lang:master Nov 4, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing e5efc33 (parent) -> f15a7f3 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard f15a7f38580ddbdc1a23909dd05cf6cc6d9f3919 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-android: 2849.9s -> 1541.8s (-45.9%)
  2. dist-ohos-aarch64: 7164.1s -> 4293.3s (-40.1%)
  3. dist-aarch64-windows-gnullvm: 7706.8s -> 4637.3s (-39.8%)
  4. dist-x86_64-freebsd: 8093.1s -> 4905.3s (-39.4%)
  5. dist-apple-various: 5900.6s -> 3659.5s (-38.0%)
  6. dist-x86_64-illumos: 9379.2s -> 5989.7s (-36.1%)
  7. dist-various-2: 3522.5s -> 2250.9s (-36.1%)
  8. dist-x86_64-windows-gnullvm: 7446.4s -> 4844.7s (-34.9%)
  9. dist-ohos-armv7: 6478.8s -> 4338.4s (-33.0%)
  10. dist-ohos-x86_64: 6481.8s -> 4366.5s (-32.6%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@lnicola lnicola deleted the sync-from-ra branch November 5, 2025 05:30
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f15a7f3): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.5% [0.5%, 0.6%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary 1.9%, secondary 2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
1.9% [1.9%, 1.9%] 1
Regressions ❌
(secondary)
2.4% [2.1%, 2.7%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.9% [1.9%, 1.9%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 473.413s -> 474.825s (0.30%)
Artifact size: 390.72 MiB -> 390.60 MiB (-0.03%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.