Update git index before running diff-index #148500
Open
+46
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
rustbot has assigned @Mark-Simulacrum. Use |
jyn514
reviewed
Nov 4, 2025
| }; | ||
|
|
||
| // We ignore the exit code, as it errors out when some files are modified. | ||
| let _ = git().args(["update-index", "--refresh", "-q"]).output(); |
There was a problem hiding this comment.
note that this discards stderr as well as stdout — you probably only want to discard stdout.
There was a problem hiding this comment.
I wanted to discard all crap from git 😆 But you're right that stderr might be useful.
There was a problem hiding this comment.
I would say keep the stderr, otherwise if the user has any git shenanigans it will be extremely confusing
|
@rustbot author |
rustbot
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed in https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/tidy.3A.20strange.20number.20of.20modified.20files/with/553714742.
This is apparently the cause of
x test tidyprinting weird number of formatted files, and also of sometimes quirky behavior of finding the files modified from a base commit.