Rollup of 6 pull requests #148507

Zalathar · 2025-11-04T23:59:22Z

Successful merges:

Add alignment parameter to simd_masked_{load,store} #147355 (Add alignment parameter to simd_masked_{load,store})
Fix tests for big-endian #147925 (Fix tests for big-endian)
compiler: Fix a couple issues around cargo feature unification #148341 (compiler: Fix a couple issues around cargo feature unification)
Dogfood trim_{suffix|prefix} in compiler #148371 (Dogfood trim_{suffix|prefix} in compiler)
Implement Path::is_empty #148495 (Implement Path::is_empty)
rustc-dev-guide subtree update #148502 (rustc-dev-guide subtree update)

r? @ghost
@rustbot modify labels: rollup

The tests fail on s390x and presumably other big-endian systems, due to check of raw alloc values in the MIR output. To fix the tests remove the raw bytes from the MIR output (via: compile-flags: -Zdump-mir-exclude-alloc-bytes) and update the matching diffs.

add tool to "enforce" semantic line breaks

sembr tool: handle a corner case

…me-tests-chapters fix another corner case for sembr tool

sembr tool: add some hints on usage

about sembr tool

Also, tidy does a lot more than follow Rust Style Guide

fix typo in autodiff docs

The first was a warning: ``` Testing stage2 {rustc_parse_format} (aarch64-apple-darwin) Compiling rustc_index v0.0.0 (/Users/ci/project/compiler/rustc_index) error: extern crate `smallvec` is unused in crate `rustc_index` --> compiler/rustc_index/src/lib.rs:2:1 | 2 | #![cfg_attr(all(feature = "nightly", test), feature(stmt_expr_attributes))] | ^ | = help: remove the dependency or add `use smallvec as _;` to the crate root = note: `-D unused-crate-dependencies` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unused_crate_dependencies)]` error: could not compile `rustc_index` (lib) due to 1 previous error ``` The second was that `type_ir_macros` didn't fully specify its dependencies: ``` Testing stage1 {rustc_type_ir_macros} (aarch64-apple-darwin) Compiling rustc_type_ir_macros v0.0.0 (/Users/jyn/src/ferrocene3/compiler/rustc_type_ir_macros) error[E0432]: unresolved import `syn::visit_mut` --> compiler/rustc_type_ir_macros/src/lib.rs:2:10 | 2 | use syn::visit_mut::VisitMut; | ^^^^^^^^^ could not find `visit_mut` in `syn` | note: found an item that was configured out --> /Users/jyn/.local/lib/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/syn-2.0.106/src/lib.rs:880:21 | 878 | #[cfg(feature = "visit-mut")] | --------------------- the item is gated behind the `visit-mut` feature 879 | #[cfg_attr(docsrs, doc(cfg(feature = "visit-mut")))] 880 | pub use crate::gen::visit_mut; | ^^^^^^^^^ error[E0433]: failed to resolve: could not find `visit_mut` in `syn` --> compiler/rustc_type_ir_macros/src/lib.rs:206:18 | 206 | syn::visit_mut::visit_type_path_mut(self, i); | ^^^^^^^^^ could not find `visit_mut` in `syn` | note: found an item that was configured out --> /Users/jyn/.local/lib/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/syn-2.0.106/src/lib.rs:880:21 | 878 | #[cfg(feature = "visit-mut")] | --------------------- the item is gated behind the `visit-mut` feature 879 | #[cfg_attr(docsrs, doc(cfg(feature = "visit-mut")))] 880 | pub use crate::gen::visit_mut; | ^^^^^^^^^ ```

This updates the rust-version file to c5dabe8.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: c5dabe8 Filtered ref: d867ed05e46e3ba4d231efe9df26fcc9310b5d09 Upstream diff: rust-lang/rust@b1b464d...c5dabe8 This merge was created using https://github.com/rust-lang/josh-sync.

Rustc pull update

This was updated recently. Also, the annotation was broken, so would not appear in date-check issue.

Zalathar · 2025-11-04T23:59:39Z

Rollup of everything.

@bors r+ rollup=never p=5

bors · 2025-11-04T23:59:42Z

📌 Commit 41382a4 has been approved by Zalathar

It is now in the queue for this repository.

bors · 2025-11-05T00:43:29Z

⌛ Testing commit 41382a4 with merge dbaea8b...

Rollup of 6 pull requests Successful merges: - #147355 (Add alignment parameter to `simd_masked_{load,store}`) - #147925 (Fix tests for big-endian) - #148341 (compiler: Fix a couple issues around cargo feature unification) - #148371 (Dogfood `trim_{suffix|prefix}` in compiler) - #148495 (Implement Path::is_empty) - #148502 (rustc-dev-guide subtree update) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-11-05T04:14:02Z

💔 Test failed - checks-actions

Zalathar · 2025-11-05T04:21:20Z

GitHub Actions isn't showing full logs for the failed job, so treating it as runner flakiness. 😿

@bors retry

bors · 2025-11-05T07:25:44Z

⌛ Testing commit 41382a4 with merge 8e0b68e...

bors · 2025-11-05T10:29:25Z

☀️ Test successful - checks-actions
Approved by: Zalathar
Pushing 8e0b68e to master...

rust-timer · 2025-11-05T10:31:13Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#147355	Add alignment parameter to `simd_masked_{load,store}`	`388aa009604c168f417e75cae4b230f2847fa29b` (link)
#147925	Fix tests for big-endian	`022be78f8d1b2e2e26ab35e583445b6566b83387` (link)
#148341	compiler: Fix a couple issues around cargo feature unificat…	`7afe48e69451ae9eb68b0403acb31d3ce5ee632c` (link)
#148371	Dogfood `trim_{suffix\|prefix}` in compiler	`d302e5c94ab0b680260b5b01bc6c58da71c003c4` (link)
#148495	Implement Path::is_empty	`96698bd49ebd63a7c71e286c2b52bfa9cb5d34d4` (link)
#148502	rustc-dev-guide subtree update	`aa2405f06714f8d71749f6aaa238a8e8d723a71a` (link)

previous master: c0ff72ffc4

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-11-05T10:33:12Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c0ff72f (parent) -> 8e0b68e (this PR)

Test differences

Show 194 test diffs

194 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 8e0b68e63cd2b7b6d18474fe6f49df6fb1570c25 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-i586-gnu-i586-i686-musl: 5489.2s -> 4844.3s (-11.7%)
x86_64-msvc-2: 6863.9s -> 7623.5s (+11.1%)
dist-aarch64-msvc: 5852.1s -> 5306.9s (-9.3%)
aarch64-msvc-1: 7350.2s -> 6802.7s (-7.4%)
dist-x86_64-solaris: 5145.2s -> 5523.5s (+7.4%)
pr-check-1: 1964.4s -> 1821.6s (-7.3%)
dist-aarch64-apple: 6090.1s -> 6532.1s (+7.3%)
dist-apple-various: 3776.0s -> 4049.3s (+7.2%)
x86_64-rust-for-linux: 2849.7s -> 2646.7s (-7.1%)
dist-i686-mingw: 9784.1s -> 9164.0s (-6.3%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-11-05T14:35:51Z

Finished benchmarking commit (8e0b68e): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.2%, 0.2%]	1
Regressions ❌ (secondary)	0.1%	[0.1%, 0.1%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.5%	[-0.9%, -0.1%]	8
All ❌✅ (primary)	0.2%	[0.2%, 0.2%]	1

Max RSS (memory usage)

Results (primary -0.2%, secondary 3.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.8%	[0.8%, 0.8%]	1
Regressions ❌ (secondary)	4.1%	[1.7%, 6.0%]	10
Improvements ✅ (primary)	-1.2%	[-1.2%, -1.2%]	1
Improvements ✅ (secondary)	-3.0%	[-3.0%, -3.0%]	1
All ❌✅ (primary)	-0.2%	[-1.2%, 0.8%]	2

Cycles

Results (primary 3.5%, secondary 2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.5%	[3.5%, 3.5%]	1
Regressions ❌ (secondary)	5.0%	[1.3%, 9.7%]	7
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.4%	[-6.6%, -4.3%]	2
All ❌✅ (primary)	3.5%	[3.5%, 3.5%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.063s -> 475.57s (0.32%)
Artifact size: 390.97 MiB -> 390.76 MiB (-0.05%)

fneddy and others added 30 commits October 21, 2025 08:30

Fix tests for big-endian

cbae956

The tests fail on s390x and presumably other big-endian systems, due to check of raw alloc values in the MIR output. To fix the tests remove the raw bytes from the MIR output (via: compile-flags: -Zdump-mir-exclude-alloc-bytes) and update the matching diffs.

add tool to check sembr

ca3e640

sample output

7dd4509

check on ci

cf99a9e

Merge pull request rust-lang#1485 from tshepang/semantic-line-breaks

86136ba

add tool to "enforce" semantic line breaks

sample output

057f15e

handle a corner case

4c0120e

Merge pull request rust-lang#2618 from rust-lang/tshepang/corner-case

804250b

sembr tool: handle a corner case

fix env use

14a9900

sample output

cc1ab93

fix corner case

0c21841

Merge pull request rust-lang#2619 from rust-lang/tshepang/reformat-so…

7f1a1b2

…me-tests-chapters fix another corner case for sembr tool

about sembr tool

08235dd

sembr tool: add some hints on usage

8654d0e

Merge pull request rust-lang#2621 from rust-lang/tshepang/sembr-help

629aeb1

sembr tool: add some hints on usage

Merge pull request rust-lang#2620 from rust-lang/tshepang-patch-2

c6344c5

about sembr tool

contributing.md: ease copy-paste

a9c7730

Also, tidy does a lot more than follow Rust Style Guide

fix typo in autodiff docs

1fbaa24

Merge pull request rust-lang#2623 from rust-lang/autodiff-typo

c6d1b14

fix typo in autodiff docs

Merge pull request rust-lang#2622 from rust-lang/master

edb4cb5

Dogfood trim_{suffix|prefix} in compiler

d28dcc7

Prepare for merging from rust-lang/rust

c850c27

This updates the rust-version file to c5dabe8.

Merge pull request rust-lang#2625 from rust-lang/rustc-pull

b72660c

Rustc pull update

Add alignment parameter to simd_masked_{load,store}

75de619

Add implementation of the alignment parameter in Miri

ffe6cf6

Implement the alignment parameter in cg_clif

21fb801

sembr src/tests/minicore.md

0588be0

date-check src/tests/minicore.md

df4d883

This was updated recently. Also, the annotation was broken, so would not appear in date-check issue.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 5, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 5, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 5, 2025

bors merged commit 8e0b68e into rust-lang:master Nov 5, 2025
12 checks passed

rustbot added this to the 1.93.0 milestone Nov 5, 2025

Zalathar deleted the rollup-vvz4knr branch November 5, 2025 10:35

rustbot added the perf-regression Performance regression. label Nov 5, 2025

This was referenced Nov 5, 2025

Add #[rustc_pass_indirectly_in_non_rustic_abis] #144529

Merged

Rollup of 4 pull requests #148472

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 6 pull requests #148507

Rollup of 6 pull requests #148507

Uh oh!

Zalathar commented Nov 4, 2025 •

edited by rustbot

Loading

Uh oh!

Zalathar commented Nov 4, 2025

Uh oh!

bors commented Nov 4, 2025

Uh oh!

bors commented Nov 5, 2025

Uh oh!

bors commented Nov 5, 2025

Uh oh!

Zalathar commented Nov 5, 2025

Uh oh!

bors commented Nov 5, 2025

Uh oh!

bors commented Nov 5, 2025

Uh oh!

Uh oh!

rust-timer commented Nov 5, 2025

Uh oh!

github-actions bot commented Nov 5, 2025

Uh oh!

rust-timer commented Nov 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

Rollup of 6 pull requests #148507

Rollup of 6 pull requests #148507

Uh oh!

Conversation

Zalathar commented Nov 4, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zalathar commented Nov 4, 2025

Uh oh!

bors commented Nov 4, 2025

Uh oh!

bors commented Nov 5, 2025

Uh oh!

bors commented Nov 5, 2025

Uh oh!

Zalathar commented Nov 5, 2025

Uh oh!

bors commented Nov 5, 2025

Uh oh!

bors commented Nov 5, 2025

Uh oh!

Uh oh!

rust-timer commented Nov 5, 2025

Uh oh!

github-actions bot commented Nov 5, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Nov 5, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

Zalathar commented Nov 4, 2025 •

edited by rustbot

Loading