-
Notifications
You must be signed in to change notification settings - Fork 13.9k
run-make tests: use edition 2024 #148528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
run-make tests: use edition 2024 #148528
Conversation
|
|
|
Can you say more on the motivation? I don't see how this change is necessarily meaningful. For user application or library code, sure, you might want to be able to use Edition 2024 niceties, but for these tests, it really makes no difference? |
|
@jieyouxu These changes are split from #147808 where I ran into test failures because these tests pull in alloc and apparently I was the first to introduce 2024 idioms into it. I thought I'd prevent other people from running into such problems by upgrading all runmake tests, but @joboet wanted some of them split off (#147808 (comment)). This PR now contains all those changes some of which are necessary for using 2024 idioms in alloc and some which are precautionary, though I did not spend time evaluating which of the other tests are likely to cause problems down the line. |
|
Okay, that seems reasonable. Can you please add that TL;DR to the PR description? Without your elaboration, the change absent the context I could not understand 😁 |
|
@jieyouxu My bad for not explaining; I figured bumping a few things was not controversial :D. Let me know if the PR description works for you. |
|
@rustbot ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@bors r+ rollup |
No worries. If this was just bumping e.g. a few tool crates to ed 2024, that'd be uninteresting and uncontroversial. However, this is modifying tests, which is why I asked for elaboration precisely because I expected that it's for a different reason than just bumping the edition for the sake of bumping the edition. |
run-make tests: use edition 2024 Bump run-make tests to edition 2024 to prevent test failures when using 2024 idioms in included code, such as I ran into here: rust-lang#147808.
run-make tests: use edition 2024 Bump run-make tests to edition 2024 to prevent test failures when using 2024 idioms in included code, such as I ran into here: rust-lang#147808.
run-make tests: use edition 2024 Bump run-make tests to edition 2024 to prevent test failures when using 2024 idioms in included code, such as I ran into here: rust-lang#147808.
run-make tests: use edition 2024 Bump run-make tests to edition 2024 to prevent test failures when using 2024 idioms in included code, such as I ran into here: rust-lang#147808.
Bump run-make tests to edition 2024 to prevent test failures when using 2024 idioms in included code, such as I ran into here: #147808.