Skip to content

Conversation

@hkBst
Copy link
Member

@hkBst hkBst commented Nov 5, 2025

Bump run-make tests to edition 2024 to prevent test failures when using 2024 idioms in included code, such as I ran into here: #147808.

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 5, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 5, 2025

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

@rustbot
Copy link
Collaborator

rustbot commented Nov 5, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@jieyouxu
Copy link
Member

jieyouxu commented Nov 6, 2025

Can you say more on the motivation? I don't see how this change is necessarily meaningful. For user application or library code, sure, you might want to be able to use Edition 2024 niceties, but for these tests, it really makes no difference?

@jieyouxu jieyouxu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2025
@hkBst
Copy link
Member Author

hkBst commented Nov 6, 2025

@jieyouxu These changes are split from #147808 where I ran into test failures because these tests pull in alloc and apparently I was the first to introduce 2024 idioms into it. I thought I'd prevent other people from running into such problems by upgrading all runmake tests, but @joboet wanted some of them split off (#147808 (comment)). This PR now contains all those changes some of which are necessary for using 2024 idioms in alloc and some which are precautionary, though I did not spend time evaluating which of the other tests are likely to cause problems down the line.

@jieyouxu
Copy link
Member

jieyouxu commented Nov 6, 2025

Okay, that seems reasonable. Can you please add that TL;DR to the PR description? Without your elaboration, the change absent the context I could not understand 😁

@hkBst
Copy link
Member Author

hkBst commented Nov 6, 2025

@jieyouxu My bad for not explaining; I figured bumping a few things was not controversial :D. Let me know if the PR description works for you.

@hkBst
Copy link
Member Author

hkBst commented Nov 6, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 6, 2025
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jieyouxu
Copy link
Member

jieyouxu commented Nov 6, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 6, 2025

📌 Commit fd6466a has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Nov 6, 2025

@jieyouxu My bad for not explaining; I figured bumping a few things was not controversial :D. Let me know if the PR description works for you.

No worries. If this was just bumping e.g. a few tool crates to ed 2024, that'd be uninteresting and uncontroversial. However, this is modifying tests, which is why I asked for elaboration precisely because I expected that it's for a different reason than just bumping the edition for the sake of bumping the edition.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 6, 2025
run-make tests: use edition 2024

Bump run-make tests to edition 2024 to prevent test failures when using 2024 idioms in included code, such as I ran into here: rust-lang#147808.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 6, 2025
run-make tests: use edition 2024

Bump run-make tests to edition 2024 to prevent test failures when using 2024 idioms in included code, such as I ran into here: rust-lang#147808.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 6, 2025
run-make tests: use edition 2024

Bump run-make tests to edition 2024 to prevent test failures when using 2024 idioms in included code, such as I ran into here: rust-lang#147808.
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 6, 2025
run-make tests: use edition 2024

Bump run-make tests to edition 2024 to prevent test failures when using 2024 idioms in included code, such as I ran into here: rust-lang#147808.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants