rustc_target: introduce Vendor #148531
Open
rustc_target: introduce Vendor #148531
+176
−118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 These commits modify compiler targets. Some changes occurred in compiler/rustc_codegen_ssa Some changes occurred in cfg and check-cfg configuration cc @Urgau The Miri subtree was changed cc @rust-lang/miri |
rustbot
added
O-apple
|
FWIW for a related change recently we had quite a bit of discussion: rust-lang/compiler-team#926. |
Improve type safety by using an enum rather than strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve type safety by using an enum rather than strings.
I'm not really sure this is better since only a few vendors have special semantics. r? @nnethercote