Merge Vec::push{,_mut}_within_capacity
#148534
Merged
+16
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
@bors + |
|
@bors ping |
|
😪 I'm awake I'm awake |
|
Ah, it was @bors r=Amanieu |
bors
added
S-waiting-on-bors
WaffleLapkin
commented
Nov 5, 2025
Comment on lines
2602
to
+2605
| #[inline] | ||
| #[unstable(feature = "vec_push_within_capacity", issue = "100486")] | ||
| pub fn push_within_capacity(&mut self, value: T) -> Result<(), T> { | ||
| self.push_mut_within_capacity(value).map(|_| ()) | ||
| // #[unstable(feature = "push_mut", issue = "135974")] | ||
| pub fn push_within_capacity(&mut self, value: T) -> Result<&mut T, T> { |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 5, 2025
…now_with_50_percent_more_mut, r=Amanieu
Merge `Vec::push{,_mut}_within_capacity`
Implements rust-lang/libs-team#689.
cc rust-lang#135974, rust-lang#100486
r? libs-api
This was referenced Nov 5, 2025
bors
added a commit
that referenced
this pull request
Nov 5, 2025
Rollup of 8 pull requests Successful merges: - #147994 (Deduplicate deprecation warning when using unit or tuple structs) - #148440 ([rustdoc search] Simplify itemTypes and filter "dependencies") - #148501 (triagebot: Create Zulip topics for libs backports) - #148517 (Remove no longer necessary lint allow) - #148518 (Unify the configuration of the compiler docs) - #148523 (miri subtree update) - #148525 (Fix ICE from lit_to_mir_constant caused by type error) - #148534 (Merge `Vec::push{,_mut}_within_capacity`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Nov 6, 2025
Rollup merge of #148534 - WaffleLapkin:push_within_capacity_now_with_50_percent_more_mut, r=Amanieu Merge `Vec::push{,_mut}_within_capacity` Implements rust-lang/libs-team#689. cc #135974, #100486 r? libs-api
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Nov 6, 2025
Rollup of 8 pull requests Successful merges: - rust-lang/rust#147994 (Deduplicate deprecation warning when using unit or tuple structs) - rust-lang/rust#148440 ([rustdoc search] Simplify itemTypes and filter "dependencies") - rust-lang/rust#148501 (triagebot: Create Zulip topics for libs backports) - rust-lang/rust#148517 (Remove no longer necessary lint allow) - rust-lang/rust#148518 (Unify the configuration of the compiler docs) - rust-lang/rust#148523 (miri subtree update) - rust-lang/rust#148525 (Fix ICE from lit_to_mir_constant caused by type error) - rust-lang/rust#148534 (Merge `Vec::push{,_mut}_within_capacity`) r? `@ghost` `@rustbot` modify labels: rollup
WaffleLapkin
deleted the
push_within_capacity_now_with_50_percent_more_mut
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements rust-lang/libs-team#689.
cc #135974, #100486
r? libs-api