Add allocator parameter to HashMap #148545
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
r? @ibraheemdev rustbot has assigned @ibraheemdev. Use |
cramertj
commented
Nov 5, 2025
| K, | ||
| V, | ||
| S = RandomState, | ||
| #[unstable(feature = "allocator_api", issue = "32838")] A: Allocator = Global, |
There was a problem hiding this comment.
Note that there is an Allocator bound on the type parameter. S = RandomState does not use a similar bound. However, hashbrown currently has this bound, so if we want to relax it to allow users to refer to non-well-formed HashMap types with nonsense allocator type parameters, that will first need to be changed upstream.
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hashbrown support originally added in rust-lang/hashbrown#133
Part of rust-lang/wg-allocators#7
See also: hashset support in #148550