Skip to content

Fix ICE from async closure variance #148561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix ICE from async closure variance #148561

wants to merge 1 commit into from
+39 −0

Conversation

@chenyukang
Copy link
Member

@chenyukang chenyukang commented Nov 6, 2025 •
edited by rustbot
Loading

Fixes #148488

The fix is also a change from #148556

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 6, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 6, 2025

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@lqd
Copy link
Member

lqd commented Nov 6, 2025

Thanks!

r? me @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 6, 2025

📌 Commit a9795db has been approved by lqd

It is now in the queue for this repository.

@rustbot rustbot assigned lqd and unassigned fee1-dead Nov 6, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2025
@JonathanBrouwer JonathanBrouwer mentioned this pull request Nov 6, 2025
Open
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 6, 2025
@matthiaskrgr
Rollup merge of rust-lang#148561 - chenyukang:yukang-fix-148488, r=lqd
806a3d1 
Fix ICE from async closure variance

Fixes rust-lang#148488

The fix is also a change from rust-lang#148556
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 6, 2025
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 6, 2025
@matthiaskrgr
Rollup merge of rust-lang#148561 - chenyukang:yukang-fix-148488, r=lqd
426cef0 
Fix ICE from async closure variance

Fixes rust-lang#148488

The fix is also a change from rust-lang#148556
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 6, 2025
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 6, 2025
@matthiaskrgr
Rollup merge of rust-lang#148561 - chenyukang:yukang-fix-148488, r=lqd
76dae76 
Fix ICE from async closure variance

Fixes rust-lang#148488

The fix is also a change from rust-lang#148556
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 6, 2025
Open
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 6, 2025
@GuillaumeGomez
Rollup merge of rust-lang#148561 - chenyukang:yukang-fix-148488, r=lqd
b9c8b5b 
Fix ICE from async closure variance

Fixes rust-lang#148488

The fix is also a change from rust-lang#148556
@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lqd lqd

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ICE Unexpected unnameable type in variance computation

5 participants

@chenyukang @rustbot @lqd @bors @fee1-dead