invalid_atomic_ordering: also lint update & try_update

[GrigorenkoPV]

Split from #148590

Tracking issue for update and try_update: #135894

[rustbot]

r? @JonathanBrouwer

rustbot has assigned @JonathanBrouwer.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[Kivooeo]

Looks good, just adds update and try_update checks the same way it was for fetch_update

One small nit:

View changes since this review

[Kivooeo]

Can you please update test name, since its now not only fetch_update test or create another test for this feature

[GrigorenkoPV]

I decided to not separate this into separate files, because it would make it more difficult to keep the tests in sync.

I tried to maybe use revisions approach, but it would still lead to each error message being written 3 times, and wouldn't really simplify the code that much.

I decided to just rename it from "fetch-update" to simply "update" as it is the word that all 3 methods have in common.

[Kivooeo]

Yeah, that's fine, let's wait on CI green

[Kivooeo]

@bors r+

[bors]

📌 Commit bd23d55 has been approved by Kivooeo

It is now in the queue for this repository.