-
Notifications
You must be signed in to change notification settings - Fork 13.9k
[DO NOT MERGE] Experiment with micro-optimizing push_str calls #148604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[DO NOT MERGE] Experiment with micro-optimizing push_str calls #148604
Conversation
|
@bors2 try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
This comment has been minimized.
This comment has been minimized.
[DO NOT MERGE] Experiment with micro-optimizing push_str calls
This comment has been minimized.
This comment has been minimized.
|
@bors try cancel |
|
Try build cancelled. Cancelled workflows: |
f04df73 to
226e775
Compare
|
@bors2 try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
[DO NOT MERGE] Experiment with micro-optimizing push_str calls
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
226e775 to
36de490
Compare
|
@bors try cancel |
|
Try build cancelled. Cancelled workflows: |
|
@bors2 try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
This comment has been minimized.
This comment has been minimized.
[DO NOT MERGE] Experiment with micro-optimizing push_str calls
|
Btw, you don't need to cancel the previous try build when making a new one. Bors will automatically cancel the previous one. |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
Queued 978d49e with parent c90bcb9, future comparison URL. |
|
Huh. CI failed but the try build didn't, is this another case of a check only being run in CI, or did something about bors change so that perf can continue even if there's an issue? |
No description provided.