Ignore #[doc(hidden)] items when computing trimmed paths for diagnostics
#148623
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
trimmed_def_pathsquery examines all items in the current crate, and all pub items in immediate-dependency crates (including the standard library), to see which item names are unique and can therefore be printed unambiguously as a bare name without a module path.Currently that query has no special handling for
#[doc(hidden)]items, which has two consequences:This PR therefore makes the
trimmed_def_pathsquery ignore external-crate items that are#[doc(hidden)], along with their descendants.As a result, hidden item names are never considered unique for trimming, and no longer interfere with visible item names being considered unique.