-
Notifications
You must be signed in to change notification settings - Fork 14k
Also compile rustc_driver as rlib #148657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This reduces the amount of patching necessary to get rustc working in environments where dynamic linking is not possible like wasm, miri or some niche OSes. There is still a single line patch necessary for miri to get the sysroot location (a future PR I have planned would as a side effect likely remove the need for this patch). For wasm some more intrusive patches are still necessary to disable thread usage. We will still only ship it in rustc-dev as dylib (all rlibs are filtered) and given that it is an empty crate, it shouldn't have any noticable size or compile time impact on building rustc.
|
r? @SparrowLii rustbot has assigned @SparrowLii. Use |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
This comment has been minimized.
This comment has been minimized.
Also compile rustc_driver as rlib
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test for f44cfc6 failed: CI. Failed jobs:
|
This reduces the amount of patching necessary to get rustc working in environments where dynamic linking is not possible like wasm, miri or some niche OSes. There is still a single line patch necessary for miri to get the sysroot location (a future PR I have planned would as a side effect likely remove the need for this patch). For wasm some more intrusive patches are still necessary to disable thread usage.
We will still only ship it in rustc-dev as dylib (all rlibs are filtered) and given that it is an empty crate, it shouldn't have any noticable size or compile time impact on building rustc.