Skip to content

Conversation

@fmease
Copy link
Member

@fmease fmease commented Nov 7, 2025

Fixes #141301.

Rambling about target_feature which I didn't touch here

Regarding #141301 (comment) (#[target_feature(enable = …)] on inlined cross-crate re-exports), it has the same underlying cause (namely, we neither encode target_feature nor AttributeKind::TargetFeature in the crate metadata). However, I didn't make that change because I first want to experiment with querying TyCtxt::codegen_fn_attrs in rustdoc instead which already works cross-crate (and also use to it for reconstructing no_mangle, export_name, link_section to avoid encoding these attributes unnecessarily (basically reverting #144050) as suggested in #144004 (comment)).

r? GuillaumeGomez

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Nov 7, 2025
@fmease fmease added the F-doc_cfg `#![feature(doc_cfg)]` label Nov 7, 2025
@GuillaumeGomez
Copy link
Member

Great, thanks! r=me once CI pass.

@rust-log-analyzer
Copy link
Collaborator

The job tidy failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
spellchecking files
building external tool typos from package typos-cli@1.38.1
finished building tool typos
npm WARN deprecated puppeteer@22.15.0: < 24.10.2 is no longer supported
npm ERR! code 127
npm ERR! git dep preparation failed
npm ERR! command /node/bin/node /node/lib/node_modules/npm/bin/npm-cli.js install --force --cache=/home/user/.npm --prefer-offline=false --prefer-online=false --offline=false --no-progress --no-save --no-audit --include=dev --include=peer --include=optional --no-package-lock-only --no-dry-run
npm ERR! npm WARN using --force Recommended protections disabled.
npm ERR! npm WARN deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm ERR! npm WARN deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm ERR! npm WARN deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm ERR! npm WARN deprecated readdir-scoped-modules@1.1.0: This functionality has been moved to @npmcli/fs
npm ERR! npm WARN deprecated debuglog@1.0.1: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm ERR! npm WARN deprecated read-package-json@2.1.2: This package is no longer supported. Please use @npmcli/package-json instead.
npm ERR! npm WARN deprecated read-installed@4.0.3: This package is no longer supported.
npm ERR! npm ERR! code 127
npm ERR! npm ERR! path /home/user/.npm/_cacache/tmp/git-cloneXXXXXXPTKYas/node_modules/rollup
npm ERR! npm ERR! command failed
npm ERR! npm ERR! command sh -c patch-package
npm ERR! npm ERR! sh: 1: patch-package: not found
npm ERR! 
npm ERR! npm ERR! A complete log of this run can be found in: /home/user/.npm/_logs/2025-11-07T17_19_17_404Z-debug-0.log

npm ERR! A complete log of this run can be found in: /home/user/.npm/_logs/2025-11-07T17_19_10_175Z-debug-0.log
npm install did not exit successfully
tidy [extra_checks]: IO error: npm install returned exit code exit status: 127
tidy [extra_checks]: FAIL
tidy: The following check failed: extra_checks
Command `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools-bin/rust-tidy /checkout /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo /checkout/obj/build 4 /node/bin/npm --extra-checks=py,cpp,js,spellcheck` failed with exit code 1
Created at: src/bootstrap/src/core/build_steps/tool.rs:1549:23
Executed at: src/bootstrap/src/core/build_steps/test.rs:1279:29

Command has failed. Rerun with -v to see more details.
Bootstrap failed while executing `test src/tools/tidy tidyselftest --extra-checks=py,cpp,js,spellcheck`
Build completed unsuccessfully in 0:02:57
  local time: Fri Nov  7 17:19:37 UTC 2025
  network time: Fri, 07 Nov 2025 17:19:37 GMT
##[error]Process completed with exit code 1.

@JonathanBrouwer
Copy link
Contributor

cfg is quite a perf sensitive attribute since it's used so much, also had problems with it during the port of cfg to the new attribute system. Lets run perf before merging to make sure this doesn't regress compile times.
@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Nov 7, 2025
Encode cfg trace, not its early counterpart to fix cross-crate `doc(auto_cfg)`
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 7, 2025
@JonathanBrouwer JonathanBrouwer added the A-attributes Area: Attributes (`#[…]`, `#![…]`) label Nov 7, 2025
@rust-bors
Copy link

rust-bors bot commented Nov 7, 2025

☀️ Try build successful (CI)
Build commit: 8d673fe (8d673fea7197257987241009c5975c1128b1e405, parent: 843f8ce2ebc01d35a30484eadc8a84cdc6130844)

@rust-timer
Copy link
Collaborator

Queued 8d673fe with parent 843f8ce, future comparison URL.
There are currently 0 preceding artifacts in the queue.
It will probably take at least ~1.3 hours until the benchmark run finishes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) F-doc_cfg `#![feature(doc_cfg)]` S-waiting-on-perf Status: Waiting on a perf run to be completed. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rustdoc no longer applies a cfg badge to certain inlined cross-crate re-exported items with a #[cfg]

6 participants