-
Notifications
You must be signed in to change notification settings - Fork 14k
Encode cfg trace, not its early counterpart to fix cross-crate doc(auto_cfg)
#148660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Great, thanks! r=me once CI pass. |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
cfg is quite a perf sensitive attribute since it's used so much, also had problems with it during the port of |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
This comment has been minimized.
This comment has been minimized.
Encode cfg trace, not its early counterpart to fix cross-crate `doc(auto_cfg)`
|
Queued 8d673fe with parent 843f8ce, future comparison URL. |
Fixes #141301.
Rambling about
target_featurewhich I didn't touch hereRegarding #141301 (comment) (
#[target_feature(enable = …)]on inlined cross-crate re-exports), it has the same underlying cause (namely, we neither encodetarget_featurenorAttributeKind::TargetFeaturein the crate metadata). However, I didn't make that change because I first want to experiment with queryingTyCtxt::codegen_fn_attrsin rustdoc instead which already works cross-crate (and also use to it for reconstructingno_mangle,export_name,link_sectionto avoid encoding these attributes unnecessarily (basically reverting #144050) as suggested in #144004 (comment)).r? GuillaumeGomez