Remove a remnant of dyn* from the parser
#148673
Open
+19
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @JonathanBrouwer. Use |
This comment has been minimized.
This comment has been minimized.
rustbot
added
S-waiting-on-author
fmease
added
the
rla-silenced
fmease
force-pushed
the
del-dyn_star-remnant
branch
from
7a3d133 to
474501b
Compare
fmease
removed
the
rla-silenced
rustbot
added
S-waiting-on-review
Contributor
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 9, 2025
…athanBrouwer Remove a remnant of `dyn*` from the parser Follow-up to rust-lang#146664 and rust-lang#143036. `is_explicit_dyn_type` still checked for `TokenKind::Star` which made no sense now that `dyn*` is no more. Removing it doesn't represent a functional change and merely affects diagnostics. That's because the check only dictated whether to interpret `dyn` as the start of a trait object type in Rust 2015 (where this identifier is only a *contextual* keyword). However, we would still fail at the `*` later on as it doesn't start a bound. While at it, I also took the time to clean up in the vicinity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #146664 and #143036.
is_explicit_dyn_typestill checked forTokenKind::Starwhich made no sense now thatdyn*is no more.Removing it doesn't represent a functional change and merely affects diagnostics. That's because the check only dictated whether to interpret
dynas the start of a trait object type in Rust 2015 (where this identifier is only a contextual keyword). However, we would still fail at the*later on as it doesn't start a bound.While at it, I also took the time to clean up in the vicinity.