Skip to content

Conversation

@dianqk
Copy link
Member

@dianqk dianqk commented Nov 8, 2025

Includes some fixes for BPF.

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 8, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 8, 2025

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Nov 8, 2025

⚠️ Warning ⚠️

@dianqk
Copy link
Member Author

dianqk commented Nov 8, 2025

cc @vadorovsky (for rust-lang/llvm-project#190)

@cuviper
Copy link
Member

cuviper commented Nov 8, 2025

@bors r+ rollup=iffy

@bors
Copy link
Collaborator

bors commented Nov 8, 2025

📌 Commit 08097c3 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 8, 2025
@bors
Copy link
Collaborator

bors commented Nov 10, 2025

⌛ Testing commit 08097c3 with merge 5f666a6...

@bors
Copy link
Collaborator

bors commented Nov 10, 2025

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 5f666a6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 10, 2025
@bors bors merged commit 5f666a6 into rust-lang:master Nov 10, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 10, 2025
@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 8401398 (parent) -> 5f666a6 (this PR)

Test differences

Show 15 test diffs

Stage 2

  • [assembly] tests/assembly-llvm/nvptx-safe-naming.rs#LLVM20: ignore (ignored when the LLVM version (21.1.3) is newer than majorversion 20) -> ignore (ignored when the LLVM version (21.1.5) is newer than majorversion 20) (J0)
  • [codegen] tests/codegen-llvm/deduced-param-attrs.rs#LLVM20: ignore (ignored when the LLVM version (21.1.3) is newer than majorversion 20) -> ignore (ignored when the LLVM version (21.1.5) is newer than majorversion 20) (J0)
  • [codegen] tests/codegen-llvm/enum/enum-discriminant-eq.rs#LLVM20: ignore (ignored when the LLVM version (21.1.3) is newer than majorversion 20) -> ignore (ignored when the LLVM version (21.1.5) is newer than majorversion 20) (J0)
  • [codegen] tests/codegen-llvm/issues/issue-122600-ptr-discriminant-update.rs#new: ignore (ignored when the LLVM version 21.1.3 is older than 22.0.0) -> ignore (ignored when the LLVM version 21.1.5 is older than 22.0.0) (J0)
  • [codegen] tests/codegen-llvm/simd-intrinsic/simd-intrinsic-generic-gather.rs#LLVM22: ignore (ignored when the LLVM version 21.1.3 is older than 22.0.0) -> ignore (ignored when the LLVM version 21.1.5 is older than 22.0.0) (J0)
  • [codegen] tests/codegen-llvm/simd-intrinsic/simd-intrinsic-generic-masked-load.rs#LLVM22: ignore (ignored when the LLVM version 21.1.3 is older than 22.0.0) -> ignore (ignored when the LLVM version 21.1.5 is older than 22.0.0) (J0)
  • [codegen] tests/codegen-llvm/simd-intrinsic/simd-intrinsic-generic-masked-store.rs#LLVM22: ignore (ignored when the LLVM version 21.1.3 is older than 22.0.0) -> ignore (ignored when the LLVM version 21.1.5 is older than 22.0.0) (J0)
  • [codegen] tests/codegen-llvm/simd-intrinsic/simd-intrinsic-generic-scatter.rs#LLVM22: ignore (ignored when the LLVM version 21.1.3 is older than 22.0.0) -> ignore (ignored when the LLVM version 21.1.5 is older than 22.0.0) (J0)
  • [codegen] tests/codegen-llvm/vec_pop_push_noop.rs#new: ignore (ignored when the LLVM version 21.1.3 is older than 22.0.0) -> ignore (ignored when the LLVM version 21.1.5 is older than 22.0.0) (J0)
  • [codegen] tests/codegen-llvm/vecdeque_pop_push.rs#new: ignore (ignored when the LLVM version 21.1.3 is older than 22.0.0) -> ignore (ignored when the LLVM version 21.1.5 is older than 22.0.0) (J0)
  • [ui] tests/ui/sanitizer/kcfi-arity-requires-llvm-21-0-0.rs: ignore (ignored when the LLVM version (21.1.3) is newer than majorversion 20) -> ignore (ignored when the LLVM version (21.1.5) is newer than majorversion 20) (J1)
  • [run-make] tests/run-make/compressed-debuginfo-zstd: pass -> ignore (ignored if LLVM wasn't build with zstd for ELF section compression or LLVM is not the default codegen backend) (J2)

Additionally, 3 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 5f666a6ec939f64d862da5af7ad5be967916390c --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. pr-check-1: 1508.5s -> 2549.4s (+69.0%)
  2. dist-apple-various: 3260.7s -> 5046.1s (+54.8%)
  3. x86_64-rust-for-linux: 2856.1s -> 4160.1s (+45.7%)
  4. x86_64-gnu-debug: 7039.1s -> 10143.7s (+44.1%)
  5. armhf-gnu: 4719.5s -> 6693.1s (+41.8%)
  6. x86_64-gnu-tools: 3461.1s -> 4881.6s (+41.0%)
  7. aarch64-gnu-debug: 4217.9s -> 5871.7s (+39.2%)
  8. x86_64-gnu-gcc: 3159.3s -> 4389.4s (+38.9%)
  9. pr-check-2: 2364.1s -> 3160.3s (+33.7%)
  10. arm-android: 5780.6s -> 7492.2s (+29.6%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@dianqk dianqk deleted the update-llvm branch November 10, 2025 07:23
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (5f666a6): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.1% [-1.1%, -1.1%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.1% [-1.1%, -1.1%] 1

Cycles

Results (secondary 2.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
7.1% [7.1%, 7.1%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.6% [-2.6%, -2.6%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 477.368s -> 475.073s (-0.48%)
Artifact size: 391.33 MiB -> 391.33 MiB (0.00%)

makai410 pushed a commit to makai410/rust that referenced this pull request Nov 10, 2025
Update LLVM to 21.1.5

Includes some fixes for BPF.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants