Skip to content

Conversation

@Zalathar
Copy link
Member

@Zalathar Zalathar commented Nov 8, 2025

Historically, LLDB debuginfo tests have used a Python script to control LLDB via its Python API, instead of invoking the lldb command directly.

Unfortunately, this requires us to find and use a version of Python that is compatible with LLDB's Python bindings.

However, it turns out that there is a simpler way to find a compatible Python interpreter: use the one that is embedded in LLDB itself, via the script command.

@rustbot
Copy link
Collaborator

rustbot commented Nov 8, 2025

This PR modifies bootstrap.example.toml.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

Some changes occurred in src/tools/compiletest

cc @jieyouxu

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Nov 8, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 8, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Zalathar
Copy link
Member Author

Zalathar commented Nov 8, 2025

@rustbot
Copy link
Collaborator

rustbot commented Nov 8, 2025

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

@jieyouxu
Copy link
Member

jieyouxu commented Nov 8, 2025

@bors try jobs=aarch64-apple

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Nov 8, 2025
compiletest: Run the `lldb_batchmode.py` script in LLDB's embedded Python

try-job: aarch64-apple
@rust-bors
Copy link

rust-bors bot commented Nov 8, 2025

☀️ Try build successful (CI)
Build commit: 9d85981 (9d85981868d8787740cfbd23500af90eabf8b01e, parent: 4e0baae06da3c29210ba3620db5b01bcb5aba38a)

@Zalathar
Copy link
Member Author

Zalathar commented Nov 8, 2025

Pushed a small tweak to explicitly specify that the script is in Python, and not some other language.

Doesn't seem to be needed in practice, but perhaps it will avoid headaches someday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants