Skip to content

Conversation

@joboet
Copy link
Member

@joboet joboet commented Nov 8, 2025

The code ignored poison errors using PoisonError anyway.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 8, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 8, 2025

r? @ChrisDenton

rustbot has assigned @ChrisDenton.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@ChrisDenton
Copy link
Member

The code ignored poison errors using PoisonError anyway.

Huh, so it did.

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 9, 2025

📌 Commit 52fd48c has been approved by ChrisDenton

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 9, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 9, 2025
…risDenton

std: use a non-poisoning `RwLock` for the panic hook

The code ignored poison errors using `PoisonError` anyway.
bors added a commit that referenced this pull request Nov 9, 2025
Rollup of 10 pull requests

Successful merges:

 - #148608 (Add test for --test-builder success path)
 - #148683 (Remove `#[const_trait]`)
 - #148687 (std: use a non-poisoning `RwLock` for the panic hook)
 - #148709 (fix: disable self-contained linker when bootstrap-override-lld is set)
 - #148716 (mgca: Finish implementation of `#[type_const]`)
 - #148722 (Add Crystal Durham to .mailmap)
 - #148723 (bootstrap: Render doctest timing reports as text, not JSON)
 - #148724 (tidy: Don't bypass stderr output capture in unit tests)
 - #148734 (miri subtree update)
 - #148736 (Fix typo in unstable-book link)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 9, 2025
…risDenton

std: use a non-poisoning `RwLock` for the panic hook

The code ignored poison errors using `PoisonError` anyway.
bors added a commit that referenced this pull request Nov 9, 2025
Rollup of 10 pull requests

Successful merges:

 - #148683 (Remove `#[const_trait]`)
 - #148687 (std: use a non-poisoning `RwLock` for the panic hook)
 - #148709 (fix: disable self-contained linker when bootstrap-override-lld is set)
 - #148716 (mgca: Finish implementation of `#[type_const]`)
 - #148722 (Add Crystal Durham to .mailmap)
 - #148723 (bootstrap: Render doctest timing reports as text, not JSON)
 - #148724 (tidy: Don't bypass stderr output capture in unit tests)
 - #148734 (miri subtree update)
 - #148736 (Fix typo in unstable-book link)
 - #148744 (Add myself(chenyukang) to the review rotation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 243d494 into rust-lang:master Nov 9, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 9, 2025
rust-timer added a commit that referenced this pull request Nov 9, 2025
Rollup merge of #148687 - joboet:nonpoison-hook-rwlock, r=ChrisDenton

std: use a non-poisoning `RwLock` for the panic hook

The code ignored poison errors using `PoisonError` anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants