Skip to content

compute temporary scopes when building MIR, not THIR #148706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

compute temporary scopes when building MIR, not THIR #148706

wants to merge 2 commits into from
+218 −453

Conversation

@dianne
Copy link
Contributor

@dianne dianne commented Nov 8, 2025 •
edited by rustbot
Loading

Based on #148658; only the last commit is new.

This accomplishes two things:

  • Makes the THIR slightly smaller by not attaching a full TempLifetime to every expression.
  • Reduces the number of traversals of the ScopeTree by only calling ScopeTree::temporary_scope when building MIR for something that needs to be dropped in a temporary scope.

dianne added 2 commits November 7, 2025 18:44
@dianne
merge RvalueScopes into ScopeTree
0e50d5a 
This removes some unneeded indirection and consolidates the logic for
scope resolution.
@dianne
compute temporary scopes when building MIR, not THIR
d186978
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 8, 2025
@dianne
Copy link
Contributor Author

dianne commented Nov 8, 2025

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

rust-timer commented Nov 8, 2025

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Nov 8, 2025
@rust-bors
Auto merge of #148706 - dianne:slightly-lazier-temporary-scoping, r=<…
9de26a5 
…try>

compute temporary scopes when building MIR, not THIR
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 8, 2025
@rust-bors
Copy link

rust-bors bot commented Nov 8, 2025

☀️ Try build successful (CI)
Build commit: 9de26a5 (9de26a5918b5655a37eefd1b02cdb1ff0cdcdc74, parent: 87f9dcd5e28a301fce81515bd4bea792444dcf29)

@rust-timer
Copy link
Collaborator

rust-timer commented Nov 8, 2025

Queued 9de26a5 with parent 87f9dcd, future comparison URL.
There are currently 2 preceding artifacts in the queue.
It will probably take at least ~3.4 hours until the benchmark run finishes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-perf Status: Waiting on a perf run to be completed. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dianne @rust-timer @rustbot