rustc_borrowck: fix async closure error note to report FnOnce rather than Fn #148713
+10
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #148391
Root cause:
asyncclosures are treated like plainFnclosures because we never updated their kind after adding the async coroutine path.Symptom:
The compiler note tells users
closure implements Fn…, which is wrong for async closures and made the error message confusing. NotablyFnMutdoes not suffer from this issue.Fix:
With this fix we treat coroutine closures as FnOnce when building that note.
Testing:
Updated a UI test stderr file to reflect the correct wording. It also clearly demonstrates what was wrong.