Skip to content

Constify ManuallyDrop::take #148752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Constify ManuallyDrop::take #148752

wants to merge 2 commits into from
+2 −1

Conversation

@nxsaken
Copy link
Contributor

@nxsaken nxsaken commented Nov 9, 2025 •
edited by rustbot
Loading

Feature: const_manually_drop_take
Tracking issue: #148773

This PR constifies ManuallyDrop::take.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 9, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 9, 2025

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@nxsaken nxsaken mentioned this pull request Nov 9, 2025
Open
@scottmcm
Copy link
Member

scottmcm commented Nov 9, 2025

As unstable? Deal 👍

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 9, 2025

📌 Commit fc4056e has been approved by scottmcm

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 9, 2025
@nxsaken
Copy link
Contributor Author

nxsaken commented Nov 10, 2025

@scottmcm I need to create a tracking issue before merging

@nxsaken nxsaken mentioned this pull request Nov 10, 2025
Open
3 tasks
@nxsaken
Copy link
Contributor Author

nxsaken commented Nov 10, 2025

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 10, 2025
@nxsaken
Copy link
Contributor Author

nxsaken commented Nov 10, 2025 •
edited
Loading

@rustbot label -S-waiting-on-author +S-waiting-on-review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@scottmcm scottmcm

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nxsaken @rustbot @scottmcm @bors