-
Notifications
You must be signed in to change notification settings - Fork 14k
add test for assoc type norm wf check #148783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
|
A job failed! Check out the build log: (web) (plain enhanced) (plain) Click to see the possible cause of the failure (guessed by this bot) |
|
|
||
| // Add GAT where clauses from the trait's definition. | ||
| // FIXME: We don't need these, since these are the type's own WF obligations. | ||
| // Add GAT where clauses from the trait's definition.This is necessary for soundness, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"This is necessary for soundness until we properly handle implied bounds on binders" or sth?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, I've already put this in the test, u want me to also add that comment here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
speaking for myself if i read these comments ill probably go "hmm that feels kinda iffy" and get confused and spend a few minutes wasting time before figuring out whats going on (e.g. from reading the test). i don't care too much though so feel free to r=me if you don't think its worth writing in the comments too
This is soundness critical 😁 sure is helpful to have tests for that. cc @rust-lang/types
r? @BoxyUwU