Skip to content

Rollup of 3 pull requests #148992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 16, 2025
Merged

Rollup of 3 pull requests #148992

merged 7 commits into from
Nov 16, 2025
+75 −64

Conversation

@Zalathar
Copy link
Member

@Zalathar Zalathar commented Nov 16, 2025 •
edited by rustbot
Loading

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

RalfJung and others added 7 commits November 9, 2025 10:13
@RalfJung
stabilize extern_system_varargs
87024bd
@weihanglo
refactor(span): rename source_len to normalized_source_len
5f38582 
This is a preparation for introducing a unnormalized source length field
@weihanglo
fix(span): track unnormalized source len for dep-info
cf57b9b 
Add `unnormalized_source_len` field to track the byte length
of source files before normalization (the original length).

`unnormalized_source_len` is for writing the correct file length
to dep-info for `-Zchecksum-hash-algorithm`
@Zalathar
Don't apply "emscripten" directives to wasm32-unknown-unknown
e53f79d
@Zalathar
Rollup merge of rust-lang#145954 - RalfJung:syscall-c-variadics, r=ja…
a528a58 
…ckh726

stabilize extern_system_varargs

Based on top of rust-lang#144066. This has been already FCP'd over there, but `@workingjubilee` has some concerns regarding "system" varargs specifically (IIUC).

Reference PR: rust-lang/reference#2069.
@Zalathar
Rollup merge of rust-lang#148962 - weihanglo:checksum, r=jieyouxu
87e6b33 
fix(span): track unnormalized source len for dep-info

Add `unnormalized_source_len` field to track the byte length
of source files before normalization (the original length).

`unnormalized_source_len` is for writing the correct file length
to dep-info for `-Zchecksum-hash-algorithm`

Fixes rust-lang#148934
@Zalathar
Rollup merge of rust-lang#148969 - Zalathar:wasm32-uwu, r=jieyouxu
943b80e 
compiletest: Don't apply "emscripten" directives to `wasm32-unknown-unknown`

This special case dates all the way back to the original introduction of the `wasm32-unknown-unknown` target, in rust-lang#45905.

Either it isn't needed, in which case we should remove it, or it *is* needed, in which case we should fix the directives in any affected tests.

Note that while the intent of this code was presumably to make `//@ ignore-emscripten` also ignore tests on w32-u-u, it has the unfortunate side-effect of also causing `//@ only-emscripten` tests to *run* on w32-u-u, which is potentially very confusing.
@rustbot rustbot added A-compiletest Area: The compiletest test runner A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Nov 16, 2025
@Zalathar
Copy link
Member Author

Zalathar commented Nov 16, 2025

Rollup of everything.

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Nov 16, 2025

📌 Commit 943b80e has been approved by Zalathar

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 16, 2025
@bors
Copy link
Collaborator

bors commented Nov 16, 2025

⌛ Testing commit 943b80e with merge b25b6ea...

@bors
Copy link
Collaborator

bors commented Nov 16, 2025

☀️ Test successful - checks-actions
Approved by: Zalathar
Pushing b25b6ea to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 16, 2025
@bors bors merged commit b25b6ea into rust-lang:main Nov 16, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 16, 2025
@rust-timer
Copy link
Collaborator

rust-timer commented Nov 16, 2025

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#145954 stabilize extern_system_varargs 25f5b2e5ee455f80c4a28e0727d0d7f68fd1f553 (link)
#148962 fix(span): track unnormalized source len for dep-info e43bc1d55b92ae6b383c5af13549608c52080343 (link)
#148969 compiletest: Don't apply "emscripten" directives to `wasm32… 1d201ee537f18b327190928f6696064eb7728f77 (link)

previous master: e1a2ec6051

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing e1a2ec6 (parent) -> b25b6ea (this PR)

Test differences

Show 10 test diffs

Stage 0

  • tests::test_unnormalized_source_length: [missing] -> pass (J0)

Stage 1

  • [ui] tests/ui/feature-gates/feature-gate-extern_system_varargs.rs: pass -> [missing] (J0)
  • tests::test_unnormalized_source_length: [missing] -> pass (J2)

Stage 2

  • [ui] tests/ui/feature-gates/feature-gate-extern_system_varargs.rs: pass -> [missing] (J1)

Additionally, 6 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard b25b6eab7fae8ab1618da45d41f017d6bc186f5b --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-gnu-aux: 7540.8s -> 6454.3s (-14.4%)
  2. dist-arm-linux-gnueabi: 4638.6s -> 5192.4s (+11.9%)
  3. i686-gnu-1: 7696.5s -> 8482.3s (+10.2%)
  4. x86_64-gnu-gcc: 3176.7s -> 3468.0s (+9.2%)
  5. x86_64-gnu-tools: 3515.2s -> 3833.5s (+9.1%)
  6. dist-powerpc-linux: 5503.1s -> 5017.4s (-8.8%)
  7. x86_64-rust-for-linux: 3007.6s -> 3252.6s (+8.1%)
  8. dist-x86_64-musl: 7269.9s -> 7827.0s (+7.7%)
  9. i686-gnu-nopt-1: 7867.0s -> 8430.9s (+7.2%)
  10. arm-android: 5886.7s -> 6303.0s (+7.1%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@bors bors mentioned this pull request Nov 16, 2025
Open
@rust-timer
Copy link
Collaborator

rust-timer commented Nov 16, 2025

Finished benchmarking commit (b25b6ea): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.8% [0.8%, 0.8%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary 2.4%, secondary 1.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 2.4% [2.4%, 2.5%] 2
Regressions ❌
(secondary)		 1.8% [1.7%, 1.8%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 2.4% [2.4%, 2.5%] 2

Binary size

Results (secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.0% [0.0%, 0.0%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Bootstrap: 473.313s -> 472.117s (-0.25%)
Artifact size: 388.72 MiB -> 388.71 MiB (-0.00%)

@Zalathar Zalathar deleted the rollup-c1aqvox branch November 17, 2025 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-compiletest Area: The compiletest test runner A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Zalathar @bors @rust-timer @rustbot @RalfJung @weihanglo