compiletest: Avoid race condition in file deletion #149004
Open
+4
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
rustbot
added
A-testsuite
Collaborator
Member
|
r? me @bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 17, 2025
… r=jieyouxu compiletest: Avoid race condition in file deletion Fixes rust-lang#149003 There is a TOCTOU when multiple threads attempt to delete the same file. Instead of pre-checking if the file exists, we can simply ignore `NotFound` errors.
bors
added a commit
that referenced
this pull request
Nov 17, 2025
Rollup of 6 pull requests Successful merges: - #147760 ([Debugger Visualizers] Unify `*-gnu` and `*-msvc` enum output) - #148505 (add larger test for `proc_macro` `FromStr` implementations) - #148855 (Error if an autodiff user does not set lto=fat) - #148958 (Run codegen tests on a 32-bit target in PR CI) - #149004 (compiletest: Avoid race condition in file deletion) - #149008 (triagebot: remove jsha from notifications for rustdoc HTML) r? `@ghost` `@rustbot` modify labels: rollup
JaclynCodes
added a commit
to JaclynCodes/rust
that referenced
this pull request
Nov 17, 2025
… r=jieyouxu compiletest: Avoid race condition in file deletion Fixes rust-lang#149003 There is a TOCTOU when multiple threads attempt to delete the same file. Instead of pre-checking if the file exists, we can simply ignore `NotFound` errors.
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 17, 2025
… r=jieyouxu compiletest: Avoid race condition in file deletion Fixes rust-lang#149003 There is a TOCTOU when multiple threads attempt to delete the same file. Instead of pre-checking if the file exists, we can simply ignore `NotFound` errors.
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 17, 2025
… r=jieyouxu compiletest: Avoid race condition in file deletion Fixes rust-lang#149003 There is a TOCTOU when multiple threads attempt to delete the same file. Instead of pre-checking if the file exists, we can simply ignore `NotFound` errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #149003
There is a TOCTOU when multiple threads attempt to delete the same file. Instead of pre-checking if the file exists, we can simply ignore
NotFounderrors.