Rollup of 6 pull requests #149009

Zalathar · 2025-11-17T01:44:15Z

Successful merges:

[Debugger Visualizers] Unify *-gnu and *-msvc enum output #147760 ([Debugger Visualizers] Unify *-gnu and *-msvc enum output)
add larger test for proc_macro FromStr implementations #148505 (add larger test for proc_macro FromStr implementations)
Error if an autodiff user does not set lto=fat #148855 (Error if an autodiff user does not set lto=fat)
Run codegen tests on a 32-bit target in PR CI #148958 (Run codegen tests on a 32-bit target in PR CI)
compiletest: Avoid race condition in file deletion #149004 (compiletest: Avoid race condition in file deletion)
triagebot: remove jsha from notifications for rustdoc HTML #149008 (triagebot: remove jsha from notifications for rustdoc HTML)

r? @ghost
@rustbot modify labels: rollup

…ulacrum [Debugger Visualizers] Unify `*-gnu` and `*-msvc` enum output Followup patch to rust-lang#145218 Ports the msvc enum synthetic/summary logic to the gnu handlers so they have identical output. Also removes the "look-through-pointers" logic that caused rust-lang#147450 <img width="629" height="220" alt="image" src="https://github.com/user-attachments/assets/d6ae44d5-232f-412d-b291-64ac52850c74" /> I know we don't run the test suite in CI anymore, but it's still useful locally so I updated the relevant tests.

add larger test for `proc_macro` `FromStr` implementations Currently, there are only few tests that check the output of `TokenStream::from_str` and `Literal::from_str` (which is somewhat understandable as the rustc implementation just delegates these calls to the parser). In preparation for both the standalone backend (rust-lang#130856) which will probably need to reimplement this logic as well as for removing panics from these functions (rust-lang#58736), this PR adds a test which shows the various messy ways of how these functions report errors and the return values for successful parses. Followup PRs such as rust-lang#147859 will change more and more of these "diagnostic + error"s into `LexErrors`. The test structure with the extra module is used to allow reusing it later easily for the standalone backend.

Error if an autodiff user does not set lto=fat Based on your feedback, I started to provide a nice error message for a lack of `lto=fat`, instead of us forcing it. In a next step, we should replace `RUSTFLAGS="-Zautodiff=Enable"` with another Cargo.toml setting, as discussed here: rust-lang#147487 (comment) As another improvement, we should also figure out why rlib builds do not properly obey the fat=lto setting. ```@bjorn3```

Run codegen tests on a 32-bit target in PR CI wasm32-wasip1 is the wasm target used in test-various. So using it somewhere else seems like a good bet.

… r=jieyouxu compiletest: Avoid race condition in file deletion Fixes rust-lang#149003 There is a TOCTOU when multiple threads attempt to delete the same file. Instead of pre-checking if the file exists, we can simply ignore `NotFound` errors.

…ouxu triagebot: remove jsha from notifications for rustdoc HTML See rust-lang/team#2083 - I'm moving to alumni status for rustdoc and no longer need these notifications.

Zalathar · 2025-11-17T01:44:46Z

Rollup of everything.

@bors r+ rollup=never p=5

bors · 2025-11-17T01:44:49Z

📌 Commit 681229c has been approved by Zalathar

It is now in the queue for this repository.

bors · 2025-11-17T02:30:09Z

⌛ Testing commit 681229c with merge 47cee57...

Rollup of 6 pull requests Successful merges: - #147760 ([Debugger Visualizers] Unify `*-gnu` and `*-msvc` enum output) - #148505 (add larger test for `proc_macro` `FromStr` implementations) - #148855 (Error if an autodiff user does not set lto=fat) - #148958 (Run codegen tests on a 32-bit target in PR CI) - #149004 (compiletest: Avoid race condition in file deletion) - #149008 (triagebot: remove jsha from notifications for rustdoc HTML) r? `@ghost` `@rustbot` modify labels: rollup

rust-log-analyzer · 2025-11-17T03:48:34Z

The job aarch64-apple failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)


---- [debuginfo-lldb] tests/debuginfo/pretty-std-collections.rs stdout ----
NOTE: compiletest thinks it is using LLDB version 1500

error: check directive(s) from `/Users/runner/work/rust/rust/tests/debuginfo/pretty-std-collections.rs` not found in debugger output. errors:
    (pretty-std-collections.rs:62) `[...] size=4 { [0] = { 0 = 1 1 = 10 } [1] = { 0 = 2 1 = 20 } [2] = { 0 = 3 1 = 30 } [3] = { 0 = 4 1 = 40 } }`
the following subset of check directive(s) was found successfully:
    (pretty-std-collections.rs:56) `(alloc::collections::vec_deque::VecDeque<int, alloc::alloc::Global>) vec_deque = size=3 { [0] = 5 [1] = 3 [2] = 7 } `
    (pretty-std-collections.rs:59) `(alloc::collections::vec_deque::VecDeque<int, alloc::alloc::Global>) vec_deque2 = size=7 { [0] = 2 [1] = 3 [2] = 4 [3] = 5 [4] = 6 [5] = 7 [6] = 8 } `
    (pretty-std-collections.rs:65) `(std::collections::hash::set::HashSet<unsigned long, core::hash::BuildHasherDefault<pretty_std_collections::SimpleHasher> >) hash_set = size=4 { [0] = 1 [1] = 2 [2] = 3 [3] = 4 } `
status: exit status: 0
command: LLDB_BATCHMODE_SCRIPT_PATH="/Users/runner/work/rust/rust/build/aarch64-apple-darwin/test/debuginfo/pretty-std-collections.lldb/pretty-std-collections.debugger.script" LLDB_BATCHMODE_TARGET_PATH="/Users/runner/work/rust/rust/build/aarch64-apple-darwin/test/debuginfo/pretty-std-collections.lldb/a" PYTHONPATH="/Users/runner/work/rust/rust/src/etc" PYTHONUNBUFFERED="1" "lldb" "--one-line" "script --language python -- import lldb_batchmode; lldb_batchmode.main()"
--- stdout -------------------------------
(lldb) script --language python -- import lldb_batchmode; lldb_batchmode.main()
LLDB batch-mode script
----------------------
Debugger commands script is '/Users/runner/work/rust/rust/build/aarch64-apple-darwin/test/debuginfo/pretty-std-collections.lldb/pretty-std-collections.debugger.script'.
Target executable is '/Users/runner/work/rust/rust/build/aarch64-apple-darwin/test/debuginfo/pretty-std-collections.lldb/a'.
Current working directory is '/Users/runner/work/rust/rust'
Creating a target for '/Users/runner/work/rust/rust/build/aarch64-apple-darwin/test/debuginfo/pretty-std-collections.lldb/a'
settings set auto-confirm true

settings set target.inherit-tcc true

version
lldb-1500.0.404.7 Apple Swift version 5.10 (swiftlang-5.10.0.13 clang-1500.3.9.4) 
command script import /Users/runner/work/rust/rust/src/etc/lldb_lookup.py
# Forces test-compliant formatting to all other types
type synthetic add -l lldb_lookup.synthetic_lookup -x ".*" --category Rust
# Std String
type synthetic add -l lldb_lookup.StdStringSyntheticProvider -x "^(alloc::([a-z_]+::)+)String$" --category Rust
type summary add -F lldb_lookup.StdStringSummaryProvider  -e -x -h "^(alloc::([a-z_]+::)+)String$" --category Rust
# Std str
type synthetic add -l lldb_lookup.synthetic_lookup -x "^&(mut )?str$" --category Rust
type summary add -F lldb_lookup.summary_lookup  -e -x -h "^&(mut )?str$" --category Rust
## MSVC
type synthetic add -l lldb_lookup.MSVCStrSyntheticProvider -x "^ref(_mut)?\$<str\$>$" --category Rust
type summary add -F lldb_lookup.StdStrSummaryProvider -e -h -x "^ref(_mut)?\$<str\$>$" --category Rust
# Array
type synthetic add -l lldb_lookup.synthetic_lookup -x "^&(mut )?\\[.+\\]$" --category Rust
type summary add -F lldb_lookup.summary_lookup  -e -x -h "^&(mut )?\\[.+\\]$" --category Rust
# Slice
## MSVC
type synthetic add -l lldb_lookup.MSVCStdSliceSyntheticProvider -x "^ref(_mut)?\$<slice2\$<.+> >" --category Rust
type summary add -F lldb_lookup.StdSliceSummaryProvider -e -x -h "^ref(_mut)?\$<slice2\$<.+> >" --category Rust
# OsString
type synthetic add -l lldb_lookup.synthetic_lookup -x "^(std::ffi::([a-z_]+::)+)OsString$" --category Rust
type summary add -F lldb_lookup.summary_lookup  -e -x -h "^(std::ffi::([a-z_]+::)+)OsString$" --category Rust
# Vec
type synthetic add -l lldb_lookup.synthetic_lookup -x "^(alloc::([a-z_]+::)+)Vec<.+>$" --category Rust
type summary add -F lldb_lookup.summary_lookup  -e -x -h "^(alloc::([a-z_]+::)+)Vec<.+>$" --category Rust
# VecDeque
type synthetic add -l lldb_lookup.synthetic_lookup -x "^(alloc::([a-z_]+::)+)VecDeque<.+>$" --category Rust
type summary add -F lldb_lookup.summary_lookup  -e -x -h "^(alloc::([a-z_]+::)+)VecDeque<.+>$" --category Rust
# BTreeSet
type synthetic add -l lldb_lookup.synthetic_lookup -x "^(alloc::([a-z_]+::)+)BTreeSet<.+>$" --category Rust
type summary add -F lldb_lookup.summary_lookup  -e -x -h "^(alloc::([a-z_]+::)+)BTreeSet<.+>$" --category Rust
# BTreeMap
type synthetic add -l lldb_lookup.synthetic_lookup -x "^(alloc::([a-z_]+::)+)BTreeMap<.+>$" --category Rust
type summary add -F lldb_lookup.summary_lookup  -e -x -h "^(alloc::([a-z_]+::)+)BTreeMap<.+>$" --category Rust
# HashMap
type synthetic add -l lldb_lookup.synthetic_lookup -x "^(std::collections::([a-z_]+::)+)HashMap<.+>$" --category Rust
type summary add -F lldb_lookup.summary_lookup  -e -x -h "^(std::collections::([a-z_]+::)+)HashMap<.+>$" --category Rust
# HashSet
type synthetic add -l lldb_lookup.synthetic_lookup -x "^(std::collections::([a-z_]+::)+)HashSet<.+>$" --category Rust
type summary add -F lldb_lookup.summary_lookup  -e -x -h "^(std::collections::([a-z_]+::)+)HashSet<.+>$" --category Rust
# Rc
type synthetic add -l lldb_lookup.synthetic_lookup -x "^(alloc::([a-z_]+::)+)Rc<.+>$" --category Rust
type summary add -F lldb_lookup.summary_lookup  -e -x -h "^(alloc::([a-z_]+::)+)Rc<.+>$" --category Rust
# Arc
type synthetic add -l lldb_lookup.synthetic_lookup -x "^(alloc::([a-z_]+::)+)Arc<.+>$" --category Rust
type summary add -F lldb_lookup.summary_lookup  -e -x -h "^(alloc::([a-z_]+::)+)Arc<.+>$" --category Rust
# Cell
type synthetic add -l lldb_lookup.synthetic_lookup -x "^(core::([a-z_]+::)+)Cell<.+>$" --category Rust
type summary add -F lldb_lookup.summary_lookup  -e -x -h "^(core::([a-z_]+::)+)Cell<.+>$" --category Rust
# RefCell
type synthetic add -l lldb_lookup.synthetic_lookup -x "^(core::([a-z_]+::)+)Ref<.+>$" --category Rust
type synthetic add -l lldb_lookup.synthetic_lookup -x "^(core::([a-z_]+::)+)RefMut<.+>$" --category Rust
type synthetic add -l lldb_lookup.synthetic_lookup -x "^(core::([a-z_]+::)+)RefCell<.+>$" --category Rust
type summary add -F lldb_lookup.summary_lookup  -e -x -h "^(core::([a-z_]+::)+)Ref<.+>$" --category Rust
type summary add -F lldb_lookup.summary_lookup  -e -x -h "^(core::([a-z_]+::)+)RefMut<.+>$" --category Rust
type summary add -F lldb_lookup.summary_lookup  -e -x -h "^(core::([a-z_]+::)+)RefCell<.+>$" --category Rust
# NonZero
type synthetic add -l lldb_lookup.synthetic_lookup -x "^(core::([a-z_]+::)+)NonZero<.+>$" --category Rust
type synthetic add -l lldb_lookup.synthetic_lookup -x "^core::num::([a-z_]+::)*NonZero.+$" --category Rust
type summary add -F lldb_lookup.summary_lookup  -e -x -h "^(core::([a-z_]+::)+)NonZero<.+>$" --category Rust
type summary add -F lldb_lookup.summary_lookup  -e -x -h "^core::num::([a-z_]+::)*NonZero.+$" --category Rust
# PathBuf
type synthetic add -l lldb_lookup.synthetic_lookup -x "^(std::([a-z_]+::)+)PathBuf$" --category Rust
type summary add -F lldb_lookup.summary_lookup  -e -x -h "^(std::([a-z_]+::)+)PathBuf$" --category Rust
# Path
type synthetic add -l lldb_lookup.synthetic_lookup -x "^&(mut )?(std::([a-z_]+::)+)Path$" --category Rust
type summary add -F lldb_lookup.summary_lookup  -e -x -h "^&(mut )?(std::([a-z_]+::)+)Path$" --category Rust
# Enum
# type summary add -F lldb_lookup.ClangEncodedEnumSummaryProvider -e -h "lldb_lookup.is_sum_type_enum" --recognizer-function --category Rust
## MSVC
type synthetic add -l lldb_lookup.MSVCEnumSyntheticProvider -x "^enum2\$<.+>$" --category Rust
type summary add -F lldb_lookup.MSVCEnumSummaryProvider -e -x -h "^enum2\$<.+>$" --category Rust
## MSVC Variants
type synthetic add -l lldb_lookup.synthetic_lookup -x "^enum2\$<.+>::.*$" --category Rust
type summary add -F lldb_lookup.summary_lookup  -e -x -h "^enum2\$<.+>::.*$" --category Rust
# Tuple
type synthetic add -l lldb_lookup.synthetic_lookup -x "^\(.*\)$" --category Rust
type summary add -F lldb_lookup.TupleSummaryProvider -e -x -h "^\(.*\)$" --category Rust
## MSVC
type synthetic add -l lldb_lookup.MSVCTupleSyntheticProvider -x "^tuple\$<.+>$" --category Rust
type summary add -F lldb_lookup.TupleSummaryProvider -e -x -h "^tuple\$<.+>$" --category Rust
type category enable Rust

breakpoint set --file 'pretty-std-collections.rs' --line 147
DEBUG: breakpoint added, id = 1
Breakpoint 1: where = a`pretty_std_collections::main::he90d76d03a0380de + 1660 at pretty-std-collections.rs:147:5, address = 0x000000010002bcfc 
DEBUG: registering breakpoint callback, id = 1
Error while trying to register breakpoint callback, id = 1, message = error: could not get num args: can't find callable: breakpoint_callback

run
Process 14973 stopped * thread #1, name = 'main', queue = 'com.apple.main-thread', stop reason = breakpoint 1.1 frame #0: 0x000000010002bcfc a`pretty_std_collections::main::he90d76d03a0380de at pretty-std-collections.rs:147:5 144 hash_set.insert(i); 145 } 146 -> 147 zzz(); // #break ^ 148 } 149 150 fn zzz() { Target 0: (a) stopped. Process 14973 launched: '/Users/runner/work/rust/rust/build/aarch64-apple-darwin/test/debuginfo/pretty-std-collections.lldb/a' (arm64) 
v vec_deque
(alloc::collections::vec_deque::VecDeque<int, alloc::alloc::Global>) vec_deque = size=3 { [0] = 5 [1] = 3 [2] = 7 } 
v vec_deque2
(alloc::collections::vec_deque::VecDeque<int, alloc::alloc::Global>) vec_deque2 = size=7 { [0] = 2 [1] = 3 [2] = 4 [3] = 5 [4] = 6 [5] = 7 [6] = 8 } 
v hash_map
(std::collections::hash::map::HashMap<unsigned long, unsigned long, core::hash::BuildHasherDefault<pretty_std_collections::SimpleHasher> >) hash_map = size=4 { [0] = (1, 10) { 0 = 1 1 = 10 } [1] = (2, 20) { 0 = 2 1 = 20 } [2] = (3, 30) { 0 = 3 1 = 30 } [3] = (4, 40) { 0 = 4 1 = 40 } } 
v hash_set
(std::collections::hash::set::HashSet<unsigned long, core::hash::BuildHasherDefault<pretty_std_collections::SimpleHasher> >) hash_set = size=4 { [0] = 1 [1] = 2 [2] = 3 [3] = 4 } 
quit
------------------------------------------
stderr: none

---- [debuginfo-lldb] tests/debuginfo/pretty-std-collections.rs stdout end ----

bors · 2025-11-17T03:49:05Z

💔 Test failed - checks-actions

Walnut356 and others added 14 commits November 10, 2025 01:35

align gnu enum output with msvc enum output

02594ac

update tests

b32411e

provide an error if an autodiff user does not set in their Cargo.toml

63f4b36

add a test to verify a good error for enabling autodiff without lto

c8bae8c

Run wasm32-wasip1 codegen tests in PR CI

64f0579

compiletest: Avoid race condition in file deletion

c287f6e

add larger test for proc_macro FromStr implementations

7194c92

Remove jsha from notifications for rustdoc HTML

70a0af3

Rollup merge of rust-lang#148958 - saethlin:32bit-codegen-pr, r=kobzol

7b3f1a9

Run codegen tests on a 32-bit target in PR CI wasm32-wasip1 is the wasm target used in test-various. So using it somewhere else seems like a good bet.

Rollup merge of rust-lang#149008 - jsha:jsha-unwatch-doc-html, r=jiey…

681229c

…ouxu triagebot: remove jsha from notifications for rustdoc HTML See rust-lang/team#2083 - I'm moving to alumni status for rustdoc and no longer need these notifications.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 17, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 17, 2025

Zalathar mentioned this pull request Nov 17, 2025

[Debugger Visualizers] Unify *-gnu and *-msvc enum output #147760

Open

Zalathar closed this Nov 17, 2025

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 17, 2025

Zalathar deleted the rollup-9q267rr branch November 17, 2025 04:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 6 pull requests #149009

Rollup of 6 pull requests #149009

Uh oh!

Zalathar commented Nov 17, 2025 •

edited by rustbot

Loading

Uh oh!

Zalathar commented Nov 17, 2025

Uh oh!

bors commented Nov 17, 2025

Uh oh!

bors commented Nov 17, 2025

Uh oh!

rust-log-analyzer commented Nov 17, 2025

Uh oh!

bors commented Nov 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Rollup of 6 pull requests #149009

Rollup of 6 pull requests #149009

Uh oh!

Conversation

Zalathar commented Nov 17, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zalathar commented Nov 17, 2025

Uh oh!

bors commented Nov 17, 2025

Uh oh!

bors commented Nov 17, 2025

Uh oh!

rust-log-analyzer commented Nov 17, 2025

Uh oh!

bors commented Nov 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Zalathar commented Nov 17, 2025 •

edited by rustbot

Loading