-
Notifications
You must be signed in to change notification settings - Fork 14.1k
rustdoc: sort stable items first #149460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
rustdoc: sort stable items first #149460
Conversation
|
Some changes occurred in HTML/CSS/JS. |
|
r? @notriddle rustbot has assigned @notriddle. Use |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A simple nit pick, but I think the release team would dislike a PR title that's backwards from the actual behavior.
The implementation itself seems okay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR title says it sorts unstable items first. This test seems to show the unstable item appearing last. Which is it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pr title was a typo, fixed (need to go back and fix the commit description too)
| return a - b; | ||
| } | ||
|
|
||
| // sort unstable items later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That confirms that title is wrong. 😉
Finally tackling this again now that the search system refactor is done. The tests and the general approach were taken from the original PR.