Skip to content

Conversation

@cyrgani
Copy link
Contributor

@cyrgani cyrgani commented Nov 29, 2025

No description provided.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 29, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 29, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Nov 29, 2025
@kryptan
Copy link
Contributor

kryptan commented Nov 29, 2025

There is also comma missing in rust_analyzer_zed.json

@rust-log-analyzer

This comment has been minimized.

@chenyukang
Copy link
Member

Thanks!
@bors r=chenyukang

@bors
Copy link
Collaborator

bors commented Nov 30, 2025

📌 Commit 33f2e82 has been approved by chenyukang

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 30, 2025
bors added a commit that referenced this pull request Nov 30, 2025
add a missing comma to default r-a settings file
@bors
Copy link
Collaborator

bors commented Nov 30, 2025

⌛ Testing commit 33f2e82 with merge 9361781...

@bors
Copy link
Collaborator

bors commented Nov 30, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 30, 2025
@Mark-Simulacrum
Copy link
Member

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 30, 2025
@bors
Copy link
Collaborator

bors commented Nov 30, 2025

⌛ Testing commit 33f2e82 with merge dfe1b8c...

@bors
Copy link
Collaborator

bors commented Dec 1, 2025

☀️ Test successful - checks-actions
Approved by: chenyukang
Pushing dfe1b8c to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 1, 2025
@bors bors merged commit dfe1b8c into rust-lang:main Dec 1, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Dec 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing b84478a (parent) -> dfe1b8c (this PR)

Test differences

Show 3 test diffs

3 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard dfe1b8c97bcde283102f706d5dcdc3649e5e12e3 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-apple: 9032.9s -> 7587.2s (-16.0%)
  2. dist-aarch64-apple: 6268.1s -> 5342.4s (-14.8%)
  3. x86_64-gnu-debug: 6755.2s -> 6038.4s (-10.6%)
  4. dist-apple-various: 3694.0s -> 3366.1s (-8.9%)
  5. i686-msvc-2: 7520.5s -> 8156.9s (+8.5%)
  6. dist-powerpc-linux: 4692.7s -> 5025.1s (+7.1%)
  7. x86_64-gnu-tools: 2806.8s -> 3002.9s (+7.0%)
  8. i686-gnu-1: 7238.7s -> 6758.7s (-6.6%)
  9. dist-aarch64-msvc: 5331.7s -> 5676.2s (+6.5%)
  10. dist-aarch64-llvm-mingw: 5709.5s -> 5362.4s (-6.1%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (dfe1b8c): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.5% [-0.5%, -0.5%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results (primary -0.0%, secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.0% [-0.0%, -0.0%] 4
Improvements ✅
(secondary)
-0.0% [-0.1%, -0.0%] 14
All ❌✅ (primary) -0.0% [-0.0%, -0.0%] 4

Bootstrap: 471.694s -> 472.475s (0.17%)
Artifact size: 386.95 MiB -> 386.89 MiB (-0.02%)

@cyrgani cyrgani deleted the comma-fix branch December 1, 2025 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants