Leverage &mut in OnceLock when possible #149469
Open
+27
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use |
tisonkun
commented
Nov 30, 2025
Comment on lines
-411
to
-412
| debug_assert!(self.is_initialized()); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Already checked in get_unchecked
tisonkun
commented
Nov 30, 2025
| if self.get_mut().is_none() { | ||
| self.initialize(f)?; | ||
| } | ||
| debug_assert!(self.is_initialized()); |
Contributor
Author
There was a problem hiding this comment.
Already checked in get_unchecked_mut
tisonkun
commented
Nov 30, 2025
|
|
||
| #[inline] | ||
| fn is_initialized(&self) -> bool { | ||
| fn initialized(&self) -> bool { |
Contributor
Author
There was a problem hiding this comment.
Aligned with initialized_mut.
is_initialized_mut doesn't follow some idioms that is_xxx would typically take &self.
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
commented
Nov 30, 2025
Comment on lines
+522
to
+529
| fn initialized_mut(&mut self) -> bool { | ||
| // `state()` does not perform an atomic load, so prefer it over `is_complete()`. | ||
| let state = self.once.state(); | ||
| match state { | ||
| OnceExclusiveState::Complete => true, | ||
| _ => false, | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This is what LazyLock already does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comments inline.