compiletest: Prepare ignore/only conditions once in advance, without a macro #149470
+248
−309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The binary crate is a tiny stub; all of the logic and tests should be in the library crate. Disabling unit tests for the binary crate makes `x test compiletest` less noisy.
Collaborator
|
Some changes occurred in src/tools/compiletest cc @jieyouxu
|
rustbot
added
A-compiletest
This commit also renames the confusing `NotADirective` outcome, and fuses it with `External` into a single `NotHandledHere` outcome.
Zalathar
force-pushed
the
prepared-conditions
branch
from
fc681fa to
b08a5fd
Compare
Member
Author
|
In the future, we should probably move towards a system where all supported ignore/only conditions are listed explicitly, and only use the |
jieyouxu
approved these changes
Dec 1, 2025
Member
|
@rustbot author |
rustbot
added
S-waiting-on-author
Zalathar
force-pushed
the
prepared-conditions
branch
from
b08a5fd to
b03a655
Compare
Member
Author
|
Added a note about condition name overlap. @rustbot ready |
rustbot
added
S-waiting-on-review
Member
|
Thanks, you can r=me once PR CI is green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiletest has historically handled
ignore-*andonly-*directives in an extremely confusing way that makes the code hard to understand and hard to modify.This PR therefore takes an important step away from that older design by instead evaluating a set of named boolean "conditions" in advance, and then using those conditions to help determine whether a particular directive should cause its test to be ignored or not.
As usual, there's more cleanup that I want to do here, but I've left most of it for future work to help keep this PR manageable.
r? jieyouxu