Tidying up UI tests [7/N] #149473
Open
Tidying up UI tests [7/N] #149473
+175
−229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/ui/invalid-module-declaration/invalid-module-declaration.rs duplicated of tests/ui/modules/missing_non_modrs_mod_inline.rs
Collaborator
|
This PR modifies |
rustbot
added
S-waiting-on-review
reddevilmidzy
commented
Nov 30, 2025
Comment on lines
+24
to
+38
| struct Bar<'a> { | ||
| data: &'a [u8], | ||
| } | ||
|
|
||
| impl<'a> Bar<'a> { | ||
| fn bar(self: &mut Bar) { | ||
| //~^ ERROR mismatched `self` parameter type | ||
| //~| NOTE expected struct `Bar<'a>` | ||
| //~| NOTE found struct `Bar<'_>` | ||
| //~| NOTE lifetime mismatch | ||
| //~| ERROR mismatched `self` parameter type | ||
| //~| NOTE expected struct `Bar<'a>` | ||
| //~| NOTE found struct `Bar<'_>` | ||
| //~| NOTE lifetime mismatch | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I merged tests/ui/issues/issue-17740.rs with tests/ui/lifetimes/explicit-self-lifetime-mismatch.rs to organize them. Is that okay? If you think it's unnecessary, I'll revert it.
Contributor
Author
There was a problem hiding this comment.
I'm not sure exactly where this test would be best placed. I've also considered placing it in tests/ui/panic, but where would be a good place?
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Intermediate commits are intended to help review, but will be squashed add comment commit prior to merge.
part of #133895
removed directory
tests/ui/explicit,tests/ui/interior-mutability,tests/ui/invalid-module-declaration, tests/ui/invalid-self-argument`r? Kivooeo