Skip to content

float::min/max: reference NaN bit pattern rules #149475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

float::min/max: reference NaN bit pattern rules #149475

wants to merge 1 commit into from
+48 −24

Conversation

@RalfJung
Copy link
Member

@RalfJung RalfJung commented Nov 30, 2025

Also, the "in particular" transition to the signed zero handling was odd, so I rearranged things a bit: first a self-contained description of the semantics, then an explanation of which operations in other standards/libraries this most closely corresponds to.

r? @tgross35

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 30, 2025
@tgross35
Copy link
Contributor

tgross35 commented Nov 30, 2025

Looks great, thanks

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 30, 2025

📌 Commit 3287178 has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 30, 2025
@RalfJung RalfJung mentioned this pull request Nov 30, 2025
Open
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 30, 2025
@matthiaskrgr
Rollup merge of rust-lang#149475 - RalfJung:min-max-nan, r=tgross35
1a9f527 
float::min/max: reference NaN bit pattern rules

Also, the "in particular" transition to the signed zero handling was odd, so I rearranged things a bit: first a self-contained description of the semantics, then an explanation of which operations in other standards/libraries this most closely corresponds to.

r? `@tgross35`
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 30, 2025
Open
bors added a commit that referenced this pull request Nov 30, 2025
@bors
Auto merge of #149478 - matthiaskrgr:rollup-0omf56q, r=matthiaskrgr
f40a70d 
Rollup of 3 pull requests

Successful merges:

 - #149236 (Clarify edge cases for Barrier::new)
 - #149444 (collapse `constness` query `match` logic)
 - #149475 (float::min/max: reference NaN bit pattern rules)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@tgross35 tgross35

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RalfJung @tgross35 @bors @rustbot