Skip to content

Rollup of 2 pull requests #149493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Rollup of 2 pull requests #149493

wants to merge 4 commits into from
+40 −36

Conversation

@matthiaskrgr
Copy link
Member

@matthiaskrgr matthiaskrgr commented Dec 1, 2025 •
edited by rustbot
Loading

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

joboet and others added 4 commits November 29, 2025 16:16
@joboet
std: don't call current_os_id from signal handler
5009847
@reddevilmidzy
Fix indent in E0591.md
d4af0f0
@matthiaskrgr
Rollup merge of rust-lang#149456 - joboet:async-safe-tid, r=Mark-Simu…
b283392 
…lacrum

std: don't call `current_os_id` from signal handler

`current_os_id` is not always async-signal-safe depending on the platform, hence it may not be called from the SIGSEGV handler. Instead, store the thread ID along with the thread name during setup. With rust-lang#144465 merged, this information is available even before the thread main function.
@matthiaskrgr
Rollup merge of rust-lang#149479 - reddevilmidzy:E0591, r=chenyukang
678e26e 
Fix indent in E0591.md

It currently looks like this.

<img width="1389" height="595" alt="image" src="https://github.com/user-attachments/assets/5336eebd-42a6-43c6-9127-9278cd82a9c2" />

https://doc.rust-lang.org/nightly/error_codes/E0591.html

So I can't run it, and the copied code has `#` in front.
@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Dec 1, 2025
@matthiaskrgr
Copy link
Member Author

matthiaskrgr commented Dec 1, 2025

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Dec 1, 2025

📌 Commit 678e26e has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 1, 2025
@bors
Copy link
Collaborator

bors commented Dec 1, 2025

⌛ Testing commit 678e26e with merge f3670dc...

bors added a commit that referenced this pull request Dec 1, 2025
@bors
Auto merge of #149493 - matthiaskrgr:rollup-rzeivkm, r=matthiaskrgr
f3670dc 
Rollup of 2 pull requests

Successful merges:

 - #149456 (std: don't call `current_os_id` from signal handler)
 - #149479 (Fix indent in E0591.md)

r? `@ghost`
`@rustbot` modify labels: rollup
@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Dec 1, 2025

The job aarch64-apple failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
failures:

---- [ui] tests/ui/runtime/out-of-stack.rs stdout ----

error: test did not exit with success! code=Some(101) so test would pass with `run-fail`
status: exit status: 101
command: cd "/Users/runner/work/rust/rust/build/aarch64-apple-darwin/test/ui/runtime/out-of-stack" && RUSTC="/Users/runner/work/rust/rust/build/aarch64-apple-darwin/stage2/bin/rustc" RUST_TEST_THREADS="3" "/Users/runner/work/rust/rust/build/aarch64-apple-darwin/test/ui/runtime/out-of-stack/a"
--- stdout -------------------------------
testing: silent-thread
testing: loud-thread

@bors
Copy link
Collaborator

bors commented Dec 1, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 1, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 1, 2025
Open
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

O-unix Operating system: Unix-like rollup A PR which is a rollup T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@matthiaskrgr @bors @rust-log-analyzer @rustbot @joboet @reddevilmidzy