Fix #148889: Add label rib when visiting delegation body #149496
+36
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
aerooneqq
force-pushed
the
ice-issue-148889
branch
from
6a42c44 to
968376d
Compare
Contributor
There was a problem hiding this comment.
it fixes the #148889 ICE.
You have to remove 'the' to have GitHub automatically close the issue.
Contributor
There was a problem hiding this comment.
I think there might be a better name for the test.
Author
There was a problem hiding this comment.
Renamed the test to "unreachable-label-ice-148889", so the reason of the error, its type and related issue is reflected in test's name. Removed "the" from the description, now the issue will be closed after merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relates to the delegation feature #118212, it fixes #148889 ICE.
r? @petrochenkov